You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Akira Ajisaka (JIRA)" <ji...@apache.org> on 2018/07/06 06:02:00 UTC

[jira] [Commented] (HADOOP-15552) Move logging APIs over to slf4j in hadoop-tools - Part2

    [ https://issues.apache.org/jira/browse/HADOOP-15552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16534453#comment-16534453 ] 

Akira Ajisaka commented on HADOOP-15552:
----------------------------------------

Thanks [~iapicker]! Mostly looks good to me. One comment:
 In TestThrottledInputStream.java and PipeMapRed.java, would you use {{LOG.info("{}", foo)}} instead of {{LOG.info(foo.toString())}}?

> Move logging APIs over to slf4j in hadoop-tools - Part2
> -------------------------------------------------------
>
>                 Key: HADOOP-15552
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15552
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Giovanni Matteo Fumarola
>            Assignee: Ian Pickering
>            Priority: Major
>         Attachments: HADOOP-15552.v1.patch, HADOOP-15552.v2.patch, HADOOP-15552.v3.patch
>
>
> Some classes in Hadoop-tools were not moved to slf4j 
> e.g. AliyunOSSInputStream.java, HadoopArchiveLogs.java, HadoopArchiveLogsRunner.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org