You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/12 09:48:00 UTC

[jira] [Commented] (FLINK-8768) Change NettyMessageDecoder to inherit from LengthFieldBasedFrameDecoder

    [ https://issues.apache.org/jira/browse/FLINK-8768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509437#comment-16509437 ] 

ASF GitHub Bot commented on FLINK-8768:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5570


> Change NettyMessageDecoder to inherit from LengthFieldBasedFrameDecoder
> -----------------------------------------------------------------------
>
>                 Key: FLINK-8768
>                 URL: https://issues.apache.org/jira/browse/FLINK-8768
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>             Fix For: 1.6.0
>
>
> Let {{NettyMessageDecoder}} inherit from {{LengthFieldBasedFrameDecoder}} instead of being an additional step in the pipeline. This does not only remove overhead in the pipeline itself but also allows use to override the {{#extractFrame()}} method to restore the old Netty 4.0.27 behaviour for non-credit based code paths which had a bug with Netty >= 4.0.28 there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)