You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/07/28 12:25:22 UTC
Review Request 61209: Log Search should stop using deprecated API for
solr
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61209/
-----------------------------------------------------------
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Bugs: AMBARI-21596
https://issues.apache.org/jira/browse/AMBARI-21596
Repository: ambari
Description
-------
Since we've switched to solrj 6.6.0 some API calls we are using are deprecated now. Let's use non-deprecated API instead.
Also suppressed some warnings and fixed the formatting of the pom file.
Diffs
-----
ambari-logsearch/ambari-logsearch-server/pom.xml ebca2d5
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrAuditAliasConfigurer.java 1eca94b
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java 225f5a3
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java 71f9f29
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/AbstractSolrConfigHandler.java 6f3d8ca
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java b6e9def
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/ReloadCollectionHandler.java 52f3366
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/solr/ResponseDataGenerator.java 74e9c11
Diff: https://reviews.apache.org/r/61209/diff/1/
Testing
-------
Tested on docker, still works :)
Thanks,
Miklos Gergely
Re: Review Request 61209: Log Search should stop using deprecated API
for solr
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61209/#review181908
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On July 28, 2017, 12:25 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61209/
> -----------------------------------------------------------
>
> (Updated July 28, 2017, 12:25 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-21596
> https://issues.apache.org/jira/browse/AMBARI-21596
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Since we've switched to solrj 6.6.0 some API calls we are using are deprecated now. Let's use non-deprecated API instead.
>
> Also suppressed some warnings and fixed the formatting of the pom file.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-server/pom.xml ebca2d5
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrAuditAliasConfigurer.java 1eca94b
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java 225f5a3
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java 71f9f29
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/AbstractSolrConfigHandler.java 6f3d8ca
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java b6e9def
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/ReloadCollectionHandler.java 52f3366
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/solr/ResponseDataGenerator.java 74e9c11
>
>
> Diff: https://reviews.apache.org/r/61209/diff/1/
>
>
> Testing
> -------
>
> Tested on docker, still works :)
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 61209: Log Search should stop using deprecated API
for solr
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61209/#review181902
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On July 28, 2017, 12:25 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61209/
> -----------------------------------------------------------
>
> (Updated July 28, 2017, 12:25 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-21596
> https://issues.apache.org/jira/browse/AMBARI-21596
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Since we've switched to solrj 6.6.0 some API calls we are using are deprecated now. Let's use non-deprecated API instead.
>
> Also suppressed some warnings and fixed the formatting of the pom file.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-server/pom.xml ebca2d5
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrAuditAliasConfigurer.java 1eca94b
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java 225f5a3
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java 71f9f29
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/AbstractSolrConfigHandler.java 6f3d8ca
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java b6e9def
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/ReloadCollectionHandler.java 52f3366
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/solr/ResponseDataGenerator.java 74e9c11
>
>
> Diff: https://reviews.apache.org/r/61209/diff/1/
>
>
> Testing
> -------
>
> Tested on docker, still works :)
>
>
> Thanks,
>
> Miklos Gergely
>
>