You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by at...@apache.org on 2016/06/23 09:21:17 UTC

[2/2] ambari git commit: AMBARI-17394 A text value edition of a slider config doesn't trigger recalculation of dependent properties. (atkach)

AMBARI-17394 A text value edition of a slider config doesn't trigger recalculation of dependent properties. (atkach)


Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/5885faff
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/5885faff
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/5885faff

Branch: refs/heads/trunk
Commit: 5885faff778503756e8971f933f5739593782d37
Parents: 4531403
Author: Andrii Tkach <at...@apache.org>
Authored: Thu Jun 23 11:40:15 2016 +0300
Committer: Andrii Tkach <at...@apache.org>
Committed: Thu Jun 23 11:40:15 2016 +0300

----------------------------------------------------------------------
 ambari-web/app/templates/common/configs/widgets/controls.hbs       | 2 +-
 .../app/views/common/configs/widgets/plain_config_text_field.js    | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ambari/blob/5885faff/ambari-web/app/templates/common/configs/widgets/controls.hbs
----------------------------------------------------------------------
diff --git a/ambari-web/app/templates/common/configs/widgets/controls.hbs b/ambari-web/app/templates/common/configs/widgets/controls.hbs
index 9c6197b..f51f7e8 100644
--- a/ambari-web/app/templates/common/configs/widgets/controls.hbs
+++ b/ambari-web/app/templates/common/configs/widgets/controls.hbs
@@ -22,7 +22,7 @@
 {{#if view.supportSwitchToTextBox}}
   {{#unless view.isPropertyUndefined}}
     <div {{bindAttr class="view.config.showAsTextBox::hide :left :widget-config-raw"}}>
-      {{view App.PlainConfigTextField sectionBinding="view.section" subSectionBinding="view.subSection" configBinding="view.config" disabledBinding="view.canNotEdit"}}
+      {{view App.PlainConfigTextField sectionBinding="view.section" subSectionBinding="view.subSection" configBinding="view.config" serviceConfigBinding="view.config" disabledBinding="view.canNotEdit"}}
     </div>
   {{/unless}}
 {{/if}}

http://git-wip-us.apache.org/repos/asf/ambari/blob/5885faff/ambari-web/app/views/common/configs/widgets/plain_config_text_field.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/views/common/configs/widgets/plain_config_text_field.js b/ambari-web/app/views/common/configs/widgets/plain_config_text_field.js
index 1403acc..cdfd347 100644
--- a/ambari-web/app/views/common/configs/widgets/plain_config_text_field.js
+++ b/ambari-web/app/views/common/configs/widgets/plain_config_text_field.js
@@ -24,6 +24,7 @@
 var App = require('app');
 require('views/common/controls_view');
 
+//TODO should use only "serviceConfig" binding instead of "config"
 App.PlainConfigTextField = Ember.View.extend(App.SupportsDependentConfigs, App.WidgetPopoverSupport, App.ValueObserver, {
   templateName: require('templates/common/configs/widgets/plain_config_text_field'),
   valueBinding: 'config.value',