You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/11/07 17:33:42 UTC
[GitHub] [incubator-ratis] szetszwo opened a new pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
szetszwo opened a new pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262
See https://issues.apache.org/jira/browse/RATIS-1138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo closed pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
szetszwo closed pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262#issuecomment-723493910
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang closed pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo merged pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
szetszwo merged pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262#issuecomment-723491320
This is actually what I have been adding in the e2e test change :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262#issuecomment-723511454
reopen pr to trigger ci
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo commented on pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262#issuecomment-723741220
It finally passed all the tests.
Thanks @runzhiwang for reviewing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo closed pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
szetszwo closed pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262#issuecomment-723492814
Oops. Sorry for my last comment. You have changed the NettyClientStreamRpc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo closed pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
szetszwo closed pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang closed pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang closed pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo closed pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
szetszwo closed pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang closed pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang closed pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
runzhiwang closed pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia edited a comment on pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
amaliujia edited a comment on pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262#issuecomment-723491320
This is actually what I have been adding in the e2e test change :) thanks for open this change and I can rebase against this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] amaliujia commented on pull request #262: RATIS-1138. Add dataStreamAddress to RaftPeer.
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #262:
URL: https://github.com/apache/incubator-ratis/pull/262#issuecomment-723492501
You will also need to update https://github.com/apache/incubator-ratis/blob/7172da0b965e295da815c2ce32deebe06c6e16ea/ratis-netty/src/main/java/org/apache/ratis/netty/client/NettyClientStreamRpc.java#L66
NettyClientStreamRpc uses `server.getDataSteamServerAddress` to build client connection to peers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org