You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/04 16:41:20 UTC
[jira] [Commented] (TINKERPOP-1151) slf4j-log4j12 / log4j is only
required for testing
[ https://issues.apache.org/jira/browse/TINKERPOP-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408085#comment-15408085 ]
ASF GitHub Bot commented on TINKERPOP-1151:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/373
TINKERPOP-1151 Made a number of changes to logging dependencies.
https://issues.apache.org/jira/browse/TINKERPOP-1151
Log4j is now generally a test dependency except for gremlin-server and gremlin-console where they need to be shipped as part of the binary distribution. In that case, they are optional scope for those who for some reason depend on those libs.
I tested this a bunch of different ways:
* `mvn clean install` shows the expected log messages
* `mvn clean install -DskipIntegrationTests` shows the expected log messages
* Gremlin Console displays log messages that aren't hidden by the default config and changes to that config allow logs to show in full
* Gremlin Server displays expected log messages
* Looked at the zip distributions and they obviously had the appropriate log4j jars
* Tested builds of both archetype outputs and logging is good within those
Anything else i missed where logging would be an issue? if not then VOTE +1 for me
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1151
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/373.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #373
----
commit 8bf021d28465b3cd88d66baaeacd380161f86086
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-08-04T16:26:43Z
Made a number of changes to logging dependencies.
Log4j is now generally a test dependency except for gremlin-server and gremlin-console where they need to be shipped as part of the binary distribution. In that case, they are optional scope for those who for some reason depend on those libs.
----
> slf4j-log4j12 / log4j is only required for testing
> --------------------------------------------------
>
> Key: TINKERPOP-1151
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1151
> Project: TinkerPop
> Issue Type: Bug
> Components: build-release
> Affects Versions: 3.1.0-incubating
> Reporter: Hendy Irawan
> Priority: Trivial
>
> Pull request: https://github.com/apache/incubator-tinkerpop/pull/229
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)