[GitHub] ashb commented on issue #3939: [AIRFLOW-3104] Add .airflowignore info into doc

[GitBox <gi...@apache.org>]

ashb commented on issue #3939: [AIRFLOW-3104] Add .airflowignore info into doc
URL: https://github.com/apache/incubator-airflow/pull/3939#issuecomment-424641567
 
 
   So extra thing about this - every directory is checked for an `.airflowignore`. I.e.
   
   ```
   $ find dags -type f
   dags/.airflowignore
   dags/x_ignored.py
   dags/y_not_ignored.py
   dags/ignored_dir/this/whole/path/is/not/even/walked
   dags/lib/.airflowignore
   dags/lib/x_ignored.py
   dags/lib/y_ignored.py
   
   $ cat dags/..airflowignore
   ignored_dir$
   x_.*\.py
   $ cat dags/libs/.airflowignore
   y_.*\.py
   ```
   
   Though I've done this from memory (and sadly didn't write tests when I fixed the behaviour. Bad Ash) so a quick check I've said the right thing would be good. The key points being that the patterns are also checked against directories (and if a dir is ignored then we don't do an `os.walk` in to it, which can speed up things) and that patterns from a parent folder are also checked against the contents of sub folders..
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services