You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/09/03 14:40:50 UTC
[GitHub] [nifi] pgyori opened a new pull request #5365: NIFI-9192: ResultSetRecordSet considers value of useLogicalTypes flag…
pgyori opened a new pull request #5365:
URL: https://github.com/apache/nifi/pull/5365
… when determining the object's schema.
Signed-off-by: Peter Gyori <pe...@gmail.com>
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
https://issues.apache.org/jira/browse/NIFI-9192
#### Description of PR
Introduces the useLogicalTypes flag to the ResultSetRecordSet and implements the logic in ResultSetRecordSet that considers the flag's value when determining the schema for the object that gets created.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pgyori commented on a change in pull request #5365: NIFI-9192: ResultSetRecordSet considers value of useLogicalTypes flag…
Posted by GitBox <gi...@apache.org>.
pgyori commented on a change in pull request #5365:
URL: https://github.com/apache/nifi/pull/5365#discussion_r708358951
##########
File path: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
##########
@@ -297,7 +271,54 @@ private DataType getDataType(final int sqlType, final ResultSet rs, final int co
}
}
- private static DataType getArrayBaseType(final Array array) throws SQLException {
+ private DataType getArrayDataType(ResultSet rs, int columnIndex, boolean useLogicalTypes) throws SQLException {
+ // The JDBC API does not allow us to know what the base type of an array is through the metadata.
+ // As a result, we have to obtain the actual Array for this record. Once we have this, we can determine
+ // the base type. However, if the base type is, itself, an array, we will simply return a base type of
+ // String because otherwise, we need the ResultSet for the array itself, and many JDBC Drivers do not
+ // support calling Array.getResultSet() and will throw an Exception if that is not supported.
+ if (rs.isAfterLast()) {
Review comment:
@mattyb149 I rebased and merged these modifications. Unfortunately I managed to do that by deleting this branch and opening a new one with the same name, so I had to create a new PR: https://github.com/apache/nifi/pull/5388
Please have a look at that if your time permits. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] pgyori closed pull request #5365: NIFI-9192: ResultSetRecordSet considers value of useLogicalTypes flag…
Posted by GitBox <gi...@apache.org>.
pgyori closed pull request #5365:
URL: https://github.com/apache/nifi/pull/5365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a change in pull request #5365: NIFI-9192: ResultSetRecordSet considers value of useLogicalTypes flag…
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on a change in pull request #5365:
URL: https://github.com/apache/nifi/pull/5365#discussion_r705635141
##########
File path: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
##########
@@ -297,7 +271,54 @@ private DataType getDataType(final int sqlType, final ResultSet rs, final int co
}
}
- private static DataType getArrayBaseType(final Array array) throws SQLException {
+ private DataType getArrayDataType(ResultSet rs, int columnIndex, boolean useLogicalTypes) throws SQLException {
+ // The JDBC API does not allow us to know what the base type of an array is through the metadata.
+ // As a result, we have to obtain the actual Array for this record. Once we have this, we can determine
+ // the base type. However, if the base type is, itself, an array, we will simply return a base type of
+ // String because otherwise, we need the ResultSet for the array itself, and many JDBC Drivers do not
+ // support calling Array.getResultSet() and will throw an Exception if that is not supported.
+ if (rs.isAfterLast()) {
Review comment:
There are merge conflicts due to a try-catch added here and some other changes via [NIFI-8376](https://issues.apache.org/jira/browse/NIFI-8376)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org