You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ws.apache.org by ve...@apache.org on 2016/01/21 21:40:11 UTC

svn commit: r1726093 - in /webservices/axiom/trunk: aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/common/factory/ axiom-api/src/main/java/org/apache/axiom/om/impl/builder/ axiom-api/src/main/java/org/apache/axiom/soap/impl/builder/ src/site...

Author: veithen
Date: Thu Jan 21 20:40:11 2016
New Revision: 1726093

URL: http://svn.apache.org/viewvc?rev=1726093&view=rev
Log:
Remove XOP and MTOM related builder classes from the public API.

Removed:
    webservices/axiom/trunk/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/XOPAwareStAXOMBuilder.java
    webservices/axiom/trunk/axiom-api/src/main/java/org/apache/axiom/om/impl/builder/XOPBuilder.java
    webservices/axiom/trunk/axiom-api/src/main/java/org/apache/axiom/soap/impl/builder/MTOMStAXSOAPModelBuilder.java
Modified:
    webservices/axiom/trunk/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/common/factory/AbstractOMMetaFactory.java
    webservices/axiom/trunk/src/site/markdown/release-notes/1.3.0.md
    webservices/axiom/trunk/systests/spring-ws-tests/pom.xml

Modified: webservices/axiom/trunk/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/common/factory/AbstractOMMetaFactory.java
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/common/factory/AbstractOMMetaFactory.java?rev=1726093&r1=1726092&r2=1726093&view=diff
==============================================================================
--- webservices/axiom/trunk/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/common/factory/AbstractOMMetaFactory.java (original)
+++ webservices/axiom/trunk/aspects/om-aspects/src/main/java/org/apache/axiom/om/impl/common/factory/AbstractOMMetaFactory.java Thu Jan 21 20:40:11 2016
@@ -38,19 +38,18 @@ import org.apache.axiom.om.OMMetaFactory
 import org.apache.axiom.om.OMXMLParserWrapper;
 import org.apache.axiom.om.impl.builder.Detachable;
 import org.apache.axiom.om.impl.builder.StAXOMBuilder;
-import org.apache.axiom.om.impl.builder.XOPAwareStAXOMBuilder;
 import org.apache.axiom.om.util.StAXParserConfiguration;
 import org.apache.axiom.om.util.StAXUtils;
 import org.apache.axiom.soap.SOAPFactory;
 import org.apache.axiom.soap.SOAPMessage;
 import org.apache.axiom.soap.SOAPModelBuilder;
-import org.apache.axiom.soap.impl.builder.MTOMStAXSOAPModelBuilder;
 import org.apache.axiom.soap.impl.builder.OMMetaFactoryEx;
 import org.apache.axiom.soap.impl.builder.StAXSOAPModelBuilder;
 import org.apache.axiom.soap.impl.intf.AxiomSOAPMessage;
 import org.apache.axiom.util.stax.XMLEventUtils;
 import org.apache.axiom.util.stax.XMLFragmentStreamReader;
 import org.apache.axiom.util.stax.xop.MimePartProvider;
+import org.apache.axiom.util.stax.xop.XOPDecodingStreamReader;
 import org.w3c.dom.Node;
 import org.xml.sax.InputSource;
 
@@ -210,10 +209,9 @@ public abstract class AbstractOMMetaFact
     public OMXMLParserWrapper createOMBuilder(StAXParserConfiguration configuration,
             OMFactory omFactory, InputSource rootPart, MimePartProvider mimePartProvider) {
         SourceInfo sourceInfo = createXMLStreamReader(configuration, rootPart, false);
-        XOPAwareStAXOMBuilder builder = new XOPAwareStAXOMBuilder(
+        StAXOMBuilder builder = new StAXOMBuilder(
                 omFactory,
-                sourceInfo.getReader(),
-                mimePartProvider,
+                new XOPDecodingStreamReader(sourceInfo.getReader(), mimePartProvider),
                 mimePartProvider instanceof Detachable ? (Detachable)mimePartProvider : null,
                 sourceInfo.getCloseable());
         builder.setAutoClose(true);
@@ -253,10 +251,10 @@ public abstract class AbstractOMMetaFact
     public SOAPModelBuilder createSOAPModelBuilder(StAXParserConfiguration configuration,
             SOAPFactory soapFactory, InputSource rootPart, MimePartProvider mimePartProvider) {
         SourceInfo sourceInfo = createXMLStreamReader(configuration, rootPart, false);
-        MTOMStAXSOAPModelBuilder builder = new MTOMStAXSOAPModelBuilder(
+        StAXSOAPModelBuilder builder = new StAXSOAPModelBuilder(
+                new XOPDecodingStreamReader(sourceInfo.getReader(), mimePartProvider),
                 soapFactory,
-                sourceInfo.getReader(),
-                mimePartProvider,
+                soapFactory.getSoapVersionURI(),
                 mimePartProvider instanceof Detachable ? (Detachable)mimePartProvider : null,
                 sourceInfo.getCloseable());
         builder.setAutoClose(true);

Modified: webservices/axiom/trunk/src/site/markdown/release-notes/1.3.0.md
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/src/site/markdown/release-notes/1.3.0.md?rev=1726093&r1=1726092&r2=1726093&view=diff
==============================================================================
--- webservices/axiom/trunk/src/site/markdown/release-notes/1.3.0.md (original)
+++ webservices/axiom/trunk/src/site/markdown/release-notes/1.3.0.md Thu Jan 21 20:40:11 2016
@@ -6,3 +6,16 @@ Changes in this release
 
 *   The public API now uses generics. Note that this should in general not have
     impact on binary compatibility with Axiom 1.2.x.
+
+*   The builder implementations and related classes have been removed from the
+    `org.apache.axiom.om.impl.builder` and `org.apache.axiom.soap.impl.builder`
+    packages. This includes the `StAXBuilder`, `StAXOMBuilder`,
+    `XOPAwareStAXOMBuilder`, `StAXSOAPModelBuilder` and `MTOMStAXSOAPModelBuilder`
+    classes.
+
+    This change was necessary to enable a refactoring and complete overhaul of
+    the builders.
+
+    As explained in the Axiom 1.2.11 release notes, application code
+    should use the `OMXMLBuilderFactory` API to create builders. Code written for
+    Axiom 1.2.x that uses that API remains compatible with Axiom 1.3.x.

Modified: webservices/axiom/trunk/systests/spring-ws-tests/pom.xml
URL: http://svn.apache.org/viewvc/webservices/axiom/trunk/systests/spring-ws-tests/pom.xml?rev=1726093&r1=1726092&r2=1726093&view=diff
==============================================================================
--- webservices/axiom/trunk/systests/spring-ws-tests/pom.xml (original)
+++ webservices/axiom/trunk/systests/spring-ws-tests/pom.xml Thu Jan 21 20:40:11 2016
@@ -74,4 +74,16 @@
             <scope>test</scope>
         </dependency>
     </dependencies>
+
+    <build>
+        <plugins>
+            <plugin>
+                <artifactId>maven-surefire-plugin</artifactId>
+                <configuration>
+                    <!-- TODO: remove this when there is a Spring-WS release compatible with Axiom 1.3.x -->
+                    <skip>true</skip>
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
 </project>