You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/06/02 15:03:34 UTC

[GitHub] [solr] HoustonPutman opened a new pull request, #891: SOLR-16231: Fix links to ref-guide pages

HoustonPutman opened a new pull request, #891:
URL: https://github.com/apache/solr/pull/891

   https://issues.apache.org/jira/browse/SOLR-16231
   
   As of the 9.0.0 release, our ref-guide page links have changed considerably. We have created redirects for most of these, but still the codebase should use the correct link structure.
   
   Note: I have found some redirects that don't work, so I will jot them down and we can try to fix them separately.
   
   Still many to do.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] HoustonPutman commented on a diff in pull request #891: SOLR-16231: Fix links to ref-guide pages

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on code in PR #891:
URL: https://github.com/apache/solr/pull/891#discussion_r906211336


##########
README.md:
##########
@@ -28,7 +28,7 @@ result faceting and highlighting.
 ## Online Documentation
 
 This README file only contains basic setup instructions.  For more
-comprehensive documentation, visit <https://solr.apache.org/guide/>
+comprehensive documentation, visit <https://solr.apache.org/guide/solr>

Review Comment:
   Yeah antora comes with a default htaccess rule to redirect `/guide` to `/guide/solr/latest/index.html`. For some reason it doesn't also redirect `/guide/solr` to `/guide/solr/latest/index.html`. So I'm going to add that to the solr-site repo.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] HoustonPutman commented on a diff in pull request #891: SOLR-16231: Fix links to ref-guide pages

Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on code in PR #891:
URL: https://github.com/apache/solr/pull/891#discussion_r906211336


##########
README.md:
##########
@@ -28,7 +28,7 @@ result faceting and highlighting.
 ## Online Documentation
 
 This README file only contains basic setup instructions.  For more
-comprehensive documentation, visit <https://solr.apache.org/guide/>
+comprehensive documentation, visit <https://solr.apache.org/guide/solr>

Review Comment:
   Yeah antora comes with a default htaccess rule to redirect `/guide` to `/guide/solr/latest/index.html`. For some reason it doesn't also redirect `/guide/solr` to `/guide/solr/latest/index.html`. So I'm going to add that to solr site as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] epugh commented on a diff in pull request #891: SOLR-16231: Fix links to ref-guide pages

Posted by GitBox <gi...@apache.org>.
epugh commented on code in PR #891:
URL: https://github.com/apache/solr/pull/891#discussion_r906195750


##########
README.md:
##########
@@ -28,7 +28,7 @@ result faceting and highlighting.
 ## Online Documentation
 
 This README file only contains basic setup instructions.  For more
-comprehensive documentation, visit <https://solr.apache.org/guide/>
+comprehensive documentation, visit <https://solr.apache.org/guide/solr>

Review Comment:
   I tested, and `https://solr.apache.org/guide/` works, `https://solr.apache.org/guide/solr` doesn't....



##########
README.md:
##########
@@ -28,7 +28,7 @@ result faceting and highlighting.
 ## Online Documentation
 
 This README file only contains basic setup instructions.  For more
-comprehensive documentation, visit <https://solr.apache.org/guide/>
+comprehensive documentation, visit <https://solr.apache.org/guide/solr>

Review Comment:
   Nevermind, I see you made a change later on to make the urls have /solr/ ;-)



##########
README.md:
##########
@@ -28,7 +28,7 @@ result faceting and highlighting.
 ## Online Documentation
 
 This README file only contains basic setup instructions.  For more
-comprehensive documentation, visit <https://solr.apache.org/guide/>
+comprehensive documentation, visit <https://solr.apache.org/guide/solr>

Review Comment:
   However, https://solr.apache.org/guide/solr/latest/configuration-guide/solr-plugins.html works, and https://solr.apache.org/guide/latest/configuration-guide/solr-plugins.html doesn't, so maybe this is okay?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] HoustonPutman merged pull request #891: SOLR-16231: Fix links to ref-guide pages

Posted by GitBox <gi...@apache.org>.
HoustonPutman merged PR #891:
URL: https://github.com/apache/solr/pull/891


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org