[GitHub] [incubator-shardingsphere] wgy8283335 commented on a change in pull request #3620: Apollo as a ConfigCenter.

[GitBox <gi...@apache.org>]

wgy8283335 commented on a change in pull request #3620: Apollo as a ConfigCenter.
URL: https://github.com/apache/incubator-shardingsphere/pull/3620#discussion_r353114992
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-center/src/main/java/org/apache/shardingsphere/orchestration/center/instance/node/ConfigTreeNode.java
 ##########
 @@ -53,29 +53,29 @@
     private Set<ConfigTreeNode> childrenNodes;
     
     /**
-     * init tree.
+     * init config tree.
      * 
      * @param instanceKeys instance Key set
      * @param keySeparator key separator
      */
-    public void initTree(final Set<String> instanceKeys, final String keySeparator) {
-        initKeysRelationship(instanceKeys, keySeparator);
-        initTree(this, SHARDING_SPHERE_KEY_ROOT);
+    public void init(final Set<String> instanceKeys, final String keySeparator) {
+        initKeysRelationships(instanceKeys, keySeparator);
+        init(this, SHARDING_SPHERE_KEY_ROOT);
     }
     
-    private void initTree(final ConfigTreeNode parentNode, final String shardingSphereKey) {
+    private void init(final ConfigTreeNode parentNode, final String shardingSphereKey) {
 
 Review comment:
   This should use another name, different from init().

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services