You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by ro...@apache.org on 2016/01/26 13:52:16 UTC
fauxton commit: updated refs/heads/master to f6d85b4
Repository: couchdb-fauxton
Updated Branches:
refs/heads/master c8518a068 -> f6d85b4a4
remove warnings on console
the warnings are displayed per default even for a valid release.
the warnings confuse people as they things something is broken,
but it is not.
this leads to a mindset were warnings are generally ignored as
the warning don't say anything about the status of the
application. this patch removes the warnings as debug logging can
get inserted again when there is something to debug.
PR: #625
PR-URL: https://github.com/apache/couchdb-fauxton/pull/625
Reviewed-By: Benjamin Keen <be...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/commit/f6d85b4a
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/tree/f6d85b4a
Diff: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/diff/f6d85b4a
Branch: refs/heads/master
Commit: f6d85b4a4675201d613feab8d66271c5bedce8e1
Parents: c8518a0
Author: Robert Kowalski <ro...@apache.org>
Authored: Fri Jan 22 14:49:23 2016 +0100
Committer: Robert Kowalski <ro...@apache.org>
Committed: Tue Jan 26 13:52:09 2016 +0100
----------------------------------------------------------------------
app/core/routeObject.js | 4 ----
1 file changed, 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/f6d85b4a/app/core/routeObject.js
----------------------------------------------------------------------
diff --git a/app/core/routeObject.js b/app/core/routeObject.js
index 33ff37f..79f6f28 100644
--- a/app/core/routeObject.js
+++ b/app/core/routeObject.js
@@ -136,8 +136,6 @@ function (FauxtonAPI, React, Backbone) {
_.each(this.reactComponents, function (componentInfo, selector) {
if ($(selector)[0]) {
React.render(React.createElement(componentInfo.component, componentInfo.props), $(selector)[0]);
- } else {
- console.warn("Unable to mount reactor component. Missing selector: ", selector);
}
});
},
@@ -263,8 +261,6 @@ function (FauxtonAPI, React, Backbone) {
if (_.has(this.reactComponents, selector)) {
if ($(selector)[0]) {
React.unmountComponentAtNode($(selector)[0]);
- } else {
- console.warn("Unable to unmount react component. Missing selector: ", selector);
}
this.reactComponents[selector] = null;
delete this.reactComponents[selector];