[GitHub] [shardingsphere] Jacob953 opened a new pull request, #22032: Add LoaderType prop for loader strategy

[GitBox <gi...@apache.org>]

Jacob953 opened a new pull request, #22032:
URL: https://github.com/apache/shardingsphere/pull/22032

   Fixes #22006.
   
   Changes proposed in this pull request:
     - Add LoaderType with GITHUB, GITEE
     - Initial INSTANCE with loaderType
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [x] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Jacob953 closed pull request #22032: Add LoaderType prop for loader strategy

[GitBox <gi...@apache.org>]

Jacob953 closed pull request #22032: Add LoaderType prop for loader strategy
URL: https://github.com/apache/shardingsphere/pull/22032


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] taojintianxia commented on a diff in pull request #22032: Add LoaderType prop for loader strategy

[GitBox <gi...@apache.org>]

taojintianxia commented on code in PR #22032:
URL: https://github.com/apache/shardingsphere/pull/22032#discussion_r1017545818


##########
test/integration-test/sql-parser/src/test/resources/env/it-env.properties:
##########
@@ -17,3 +17,5 @@
 
 sql.parser.it.enabled=false
 sql.parser.it.report.path=/tmp/
+# sql.parser.it.loader=github,gitee,local
+sql.parser.it.loader=github

Review Comment:
   as I know, in the following refactor process, you will apply the strategy pattern. but from this config file, I realized this may not be a strategy pattern .
   please think about it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org