You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hilco Wijbenga (JIRA)" <ji...@codehaus.org> on 2007/02/15 02:04:21 UTC

[jira] Created: (CONTINUUM-1167) Patch to add JBoss support

Patch to add JBoss support
--------------------------

                 Key: CONTINUUM-1167
                 URL: http://jira.codehaus.org/browse/CONTINUUM-1167
             Project: Continuum
          Issue Type: Wish
            Reporter: Hilco Wijbenga
            Priority: Minor
         Attachments: continuum_jboss.patch

I've been bold enough to prepare a little patch that adds explicit
support for JBoss to the Continuum WAR.

The patch adds a jboss-web.xml file (this should be totally harmless)
and adds two <resource-ref>s to web.xml. I get the impression that
this latter change is harmless as well, or would it break other app
servers?

Anyway, here's the patch. I hope it can get applied, otherwise I'll
just keep on doing it by hand. :-) With this applied the only thing
left to do is add a derby-ds.xml file to the JBoss deployment
directory. And make sure JBoss has a Derby driver, of course.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CONTINUUM-1167) Patch to add JBoss support

Posted by "Jesse McConnell (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/CONTINUUM-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse McConnell updated CONTINUUM-1167:
---------------------------------------

    Fix Version/s: 1.1-alpha-2

> Patch to add JBoss support
> --------------------------
>
>                 Key: CONTINUUM-1167
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1167
>             Project: Continuum
>          Issue Type: Wish
>            Reporter: Hilco Wijbenga
>            Priority: Minor
>             Fix For: 1.1-alpha-2
>
>         Attachments: continuum_jboss.patch, continuum_jboss_2.patch, continuum_jboss_2.patch
>
>
> I've been bold enough to prepare a little patch that adds explicit
> support for JBoss to the Continuum WAR.
> The patch adds a jboss-web.xml file (this should be totally harmless)
> and adds two <resource-ref>s to web.xml. I get the impression that
> this latter change is harmless as well, or would it break other app
> servers?
> Anyway, here's the patch. I hope it can get applied, otherwise I'll
> just keep on doing it by hand. :-) With this applied the only thing
> left to do is add a derby-ds.xml file to the JBoss deployment
> directory. And make sure JBoss has a Derby driver, of course.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CONTINUUM-1167) Patch to add JBoss support

Posted by "thierry lach (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/CONTINUUM-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

thierry lach updated CONTINUUM-1167:
------------------------------------

    Attachment: continuum_jboss_2.patch

OK this patch file might work a little better - I didn't realize that creating a patch through Eclipse put full path names into the patch file.

> Patch to add JBoss support
> --------------------------
>
>                 Key: CONTINUUM-1167
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1167
>             Project: Continuum
>          Issue Type: Wish
>            Reporter: Hilco Wijbenga
>            Priority: Minor
>         Attachments: continuum_jboss.patch, continuum_jboss_2.patch, continuum_jboss_2.patch
>
>
> I've been bold enough to prepare a little patch that adds explicit
> support for JBoss to the Continuum WAR.
> The patch adds a jboss-web.xml file (this should be totally harmless)
> and adds two <resource-ref>s to web.xml. I get the impression that
> this latter change is harmless as well, or would it break other app
> servers?
> Anyway, here's the patch. I hope it can get applied, otherwise I'll
> just keep on doing it by hand. :-) With this applied the only thing
> left to do is add a derby-ds.xml file to the JBoss deployment
> directory. And make sure JBoss has a Derby driver, of course.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (CONTINUUM-1167) Patch to add JBoss support

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/CONTINUUM-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Venisse closed CONTINUUM-1167.
---------------------------------------

      Assignee: Emmanuel Venisse
    Resolution: Fixed

Patch applied without continuum-ear profile

> Patch to add JBoss support
> --------------------------
>
>                 Key: CONTINUUM-1167
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1167
>             Project: Continuum
>          Issue Type: Wish
>            Reporter: Hilco Wijbenga
>            Assignee: Emmanuel Venisse
>            Priority: Minor
>             Fix For: 1.1-beta-3
>
>         Attachments: continuum_jboss.patch, continuum_jboss_2.patch, continuum_jboss_2.patch
>
>
> I've been bold enough to prepare a little patch that adds explicit
> support for JBoss to the Continuum WAR.
> The patch adds a jboss-web.xml file (this should be totally harmless)
> and adds two <resource-ref>s to web.xml. I get the impression that
> this latter change is harmless as well, or would it break other app
> servers?
> Anyway, here's the patch. I hope it can get applied, otherwise I'll
> just keep on doing it by hand. :-) With this applied the only thing
> left to do is add a derby-ds.xml file to the JBoss deployment
> directory. And make sure JBoss has a Derby driver, of course.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CONTINUUM-1167) Patch to add JBoss support

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/CONTINUUM-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Venisse updated CONTINUUM-1167:
----------------------------------------

    Fix Version/s:     (was: 1.1-beta-1)
                   1.1-beta-2

> Patch to add JBoss support
> --------------------------
>
>                 Key: CONTINUUM-1167
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1167
>             Project: Continuum
>          Issue Type: Wish
>            Reporter: Hilco Wijbenga
>            Priority: Minor
>             Fix For: 1.1-beta-2
>
>         Attachments: continuum_jboss.patch, continuum_jboss_2.patch, continuum_jboss_2.patch
>
>
> I've been bold enough to prepare a little patch that adds explicit
> support for JBoss to the Continuum WAR.
> The patch adds a jboss-web.xml file (this should be totally harmless)
> and adds two <resource-ref>s to web.xml. I get the impression that
> this latter change is harmless as well, or would it break other app
> servers?
> Anyway, here's the patch. I hope it can get applied, otherwise I'll
> just keep on doing it by hand. :-) With this applied the only thing
> left to do is add a derby-ds.xml file to the JBoss deployment
> directory. And make sure JBoss has a Derby driver, of course.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (CONTINUUM-1167) Patch to add JBoss support

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/CONTINUUM-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_104317 ] 

Emmanuel Venisse commented on CONTINUUM-1167:
---------------------------------------------

Thierry,

I'll can look at your patch if you attach continuum-ear too ;)

> Patch to add JBoss support
> --------------------------
>
>                 Key: CONTINUUM-1167
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1167
>             Project: Continuum
>          Issue Type: Wish
>            Reporter: Hilco Wijbenga
>            Priority: Minor
>             Fix For: 1.1-beta-2
>
>         Attachments: continuum_jboss.patch, continuum_jboss_2.patch, continuum_jboss_2.patch
>
>
> I've been bold enough to prepare a little patch that adds explicit
> support for JBoss to the Continuum WAR.
> The patch adds a jboss-web.xml file (this should be totally harmless)
> and adds two <resource-ref>s to web.xml. I get the impression that
> this latter change is harmless as well, or would it break other app
> servers?
> Anyway, here's the patch. I hope it can get applied, otherwise I'll
> just keep on doing it by hand. :-) With this applied the only thing
> left to do is add a derby-ds.xml file to the JBoss deployment
> directory. And make sure JBoss has a Derby driver, of course.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CONTINUUM-1167) Patch to add JBoss support

Posted by "thierry lach (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/CONTINUUM-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

thierry lach updated CONTINUUM-1167:
------------------------------------

    Attachment: continuum_jboss_2.patch

I've added to the patch a little bit.  

It contains a fix so that email can get sent.  

It also contains a new module to create an ear file for the war.  This is only activated through a profile named "ear", so to create the ear file you must "mvn -Pear .....".  The context root is defined in the main pom and can be overridden using -Dcontinuum.ear.contextRoot=whateverYouWantItToBe.


> Patch to add JBoss support
> --------------------------
>
>                 Key: CONTINUUM-1167
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1167
>             Project: Continuum
>          Issue Type: Wish
>            Reporter: Hilco Wijbenga
>            Priority: Minor
>         Attachments: continuum_jboss.patch, continuum_jboss_2.patch
>
>
> I've been bold enough to prepare a little patch that adds explicit
> support for JBoss to the Continuum WAR.
> The patch adds a jboss-web.xml file (this should be totally harmless)
> and adds two <resource-ref>s to web.xml. I get the impression that
> this latter change is harmless as well, or would it break other app
> servers?
> Anyway, here's the patch. I hope it can get applied, otherwise I'll
> just keep on doing it by hand. :-) With this applied the only thing
> left to do is add a derby-ds.xml file to the JBoss deployment
> directory. And make sure JBoss has a Derby driver, of course.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CONTINUUM-1167) Patch to add JBoss support

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/CONTINUUM-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated CONTINUUM-1167:
------------------------------------

    Patch Submitted: [Yes]

> Patch to add JBoss support
> --------------------------
>
>                 Key: CONTINUUM-1167
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1167
>             Project: Continuum
>          Issue Type: Wish
>            Reporter: Hilco Wijbenga
>            Priority: Minor
>             Fix For: 1.1-beta-2
>
>         Attachments: continuum_jboss.patch, continuum_jboss_2.patch, continuum_jboss_2.patch
>
>
> I've been bold enough to prepare a little patch that adds explicit
> support for JBoss to the Continuum WAR.
> The patch adds a jboss-web.xml file (this should be totally harmless)
> and adds two <resource-ref>s to web.xml. I get the impression that
> this latter change is harmless as well, or would it break other app
> servers?
> Anyway, here's the patch. I hope it can get applied, otherwise I'll
> just keep on doing it by hand. :-) With this applied the only thing
> left to do is add a derby-ds.xml file to the JBoss deployment
> directory. And make sure JBoss has a Derby driver, of course.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (CONTINUUM-1167) Patch to add JBoss support

Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/CONTINUUM-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Emmanuel Venisse updated CONTINUUM-1167:
----------------------------------------

    Fix Version/s:     (was: 1.1-beta-2)
                   1.1-beta-3

> Patch to add JBoss support
> --------------------------
>
>                 Key: CONTINUUM-1167
>                 URL: http://jira.codehaus.org/browse/CONTINUUM-1167
>             Project: Continuum
>          Issue Type: Wish
>            Reporter: Hilco Wijbenga
>            Priority: Minor
>             Fix For: 1.1-beta-3
>
>         Attachments: continuum_jboss.patch, continuum_jboss_2.patch, continuum_jboss_2.patch
>
>
> I've been bold enough to prepare a little patch that adds explicit
> support for JBoss to the Continuum WAR.
> The patch adds a jboss-web.xml file (this should be totally harmless)
> and adds two <resource-ref>s to web.xml. I get the impression that
> this latter change is harmless as well, or would it break other app
> servers?
> Anyway, here's the patch. I hope it can get applied, otherwise I'll
> just keep on doing it by hand. :-) With this applied the only thing
> left to do is add a derby-ds.xml file to the JBoss deployment
> directory. And make sure JBoss has a Derby driver, of course.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira