You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/13 15:58:45 UTC

[GitHub] [hudi] codope opened a new pull request #4591: Revert "[HUDI-3233] Make metadata commit synchronous for flink batch"

codope opened a new pull request #4591:
URL: https://github.com/apache/hudi/pull/4591


   This reverts commit 2969fb3835b96dbd31fdbca536e8f370abb264c6.
   
   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4591: Revert "[HUDI-3233] Make metadata commit synchronous for flink batch"

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4591:
URL: https://github.com/apache/hudi/pull/4591#issuecomment-1012278717


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3657d3ab571be7249abea0132459f9c09890f156",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5203",
       "triggerID" : "3657d3ab571be7249abea0132459f9c09890f156",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3657d3ab571be7249abea0132459f9c09890f156 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5203) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4591: Revert "[HUDI-3233] Make metadata commit synchronous for flink batch"

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4591:
URL: https://github.com/apache/hudi/pull/4591#issuecomment-1012275442


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3657d3ab571be7249abea0132459f9c09890f156",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3657d3ab571be7249abea0132459f9c09890f156",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3657d3ab571be7249abea0132459f9c09890f156 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4591: Revert "[HUDI-3233] Make metadata commit synchronous for flink batch"

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4591:
URL: https://github.com/apache/hudi/pull/4591#issuecomment-1012275442


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3657d3ab571be7249abea0132459f9c09890f156",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "3657d3ab571be7249abea0132459f9c09890f156",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3657d3ab571be7249abea0132459f9c09890f156 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #4591: Revert "[HUDI-3233] Make metadata commit synchronous for flink batch"

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4591:
URL: https://github.com/apache/hudi/pull/4591#issuecomment-1013041993


   @codope : was this an attempt to fix the flakiness ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codope commented on pull request #4591: Revert "[HUDI-3233] Make metadata commit synchronous for flink batch"

Posted by GitBox <gi...@apache.org>.
codope commented on pull request #4591:
URL: https://github.com/apache/hudi/pull/4591#issuecomment-1013631866


   > @codope : was this an attempt to fix the flakiness ?
   
   Yeah, closing this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4591: Revert "[HUDI-3233] Make metadata commit synchronous for flink batch"

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4591:
URL: https://github.com/apache/hudi/pull/4591#issuecomment-1012331395


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3657d3ab571be7249abea0132459f9c09890f156",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5203",
       "triggerID" : "3657d3ab571be7249abea0132459f9c09890f156",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3657d3ab571be7249abea0132459f9c09890f156 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5203) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on pull request #4591: Revert "[HUDI-3233] Make metadata commit synchronous for flink batch"

Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #4591:
URL: https://github.com/apache/hudi/pull/4591#issuecomment-1012646560


   Why revert the PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4591: Revert "[HUDI-3233] Make metadata commit synchronous for flink batch"

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4591:
URL: https://github.com/apache/hudi/pull/4591#issuecomment-1012278717


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "3657d3ab571be7249abea0132459f9c09890f156",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5203",
       "triggerID" : "3657d3ab571be7249abea0132459f9c09890f156",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 3657d3ab571be7249abea0132459f9c09890f156 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5203) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codope closed pull request #4591: Revert "[HUDI-3233] Make metadata commit synchronous for flink batch"

Posted by GitBox <gi...@apache.org>.
codope closed pull request #4591:
URL: https://github.com/apache/hudi/pull/4591


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org