You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/14 01:00:26 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #22965: Upgrade to support Google Ads v10

potiuk commented on code in PR #22965:
URL: https://github.com/apache/airflow/pull/22965#discussion_r850003787


##########
setup.cfg:
##########
@@ -91,7 +91,7 @@ install_requires =
     # Cattrs upgrades were known to break lineage https://github.com/apache/airflow/issues/16172
     # TODO: Cattrs is now at 3.8 version so we should attempt to upgrade cattrs soon.
     cattrs~=1.1, !=1.7.*
-    colorlog>=4.0.2
+    colorlog>=4.0.2, <5.0

Review Comment:
   We should describae why we limited it - which tests failed - ideally what were the proble and what we need to fix it. 
   
   Or maybe we can fix it ? I doubt colorlog has some "really big" changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org