You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by si...@apache.org on 2012/12/13 07:26:33 UTC

svn commit: r1421083 - in /zookeeper/bookkeeper/trunk: CHANGES.txt hedwig-client/src/main/java/org/apache/hedwig/client/api/Subscriber.java

Author: sijie
Date: Thu Dec 13 06:26:32 2012
New Revision: 1421083

URL: http://svn.apache.org/viewvc?rev=1421083&view=rev
Log:
BOOKKEEPER-404: Deprecate non-SubscriptionOptions Subscriber Apis (ivank via sijie)

Modified:
    zookeeper/bookkeeper/trunk/CHANGES.txt
    zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/api/Subscriber.java

Modified: zookeeper/bookkeeper/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/CHANGES.txt?rev=1421083&r1=1421082&r2=1421083&view=diff
==============================================================================
--- zookeeper/bookkeeper/trunk/CHANGES.txt (original)
+++ zookeeper/bookkeeper/trunk/CHANGES.txt Thu Dec 13 06:26:32 2012
@@ -306,6 +306,8 @@ Trunk (unreleased changes)
 
         BOOKKEEPER-453: Extract commonality from MultiplexSubscribeResponseHandler and SimpleSubscribeResponseHandler and put into an abstract class  (sijie via ivank)
 
+        BOOKKEEPER-404: Deprecate non-SubscriptionOptions Subscriber Apis (ivank via sijie)
+
 Release 4.1.0 - 2012-06-07
 
   Non-backward compatible changes:

Modified: zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/api/Subscriber.java
URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/api/Subscriber.java?rev=1421083&r1=1421082&r2=1421083&view=diff
==============================================================================
--- zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/api/Subscriber.java (original)
+++ zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/api/Subscriber.java Thu Dec 13 06:26:32 2012
@@ -59,7 +59,12 @@ public interface Subscriber {
      *             If the subscriberId is not valid. We may want to set aside
      *             certain formats of subscriberId's for different purposes.
      *             e.g. local vs. hub subscriber
+     * @deprecated As of BookKeeper 4.2.0, replaced by
+     *             {@link Subscriber#subscribe(com.google.protobuf.ByteString,
+     *                                         com.google.protobuf.ByteString,
+     *                                         PubSubProtocol.SubscriptionOptions)}
      */
+    @Deprecated
     public void subscribe(ByteString topic, ByteString subscriberId, CreateOrAttach mode)
             throws CouldNotConnectException, ClientAlreadySubscribedException, ServiceDownException,
         InvalidSubscriberIdException;
@@ -82,7 +87,12 @@ public interface Subscriber {
      * @param context
      *            Calling context that the Callback needs since this is done
      *            asynchronously.
+     * @deprecated As of BookKeeper 4.2.0, replaced by
+     *             {@link Subscriber#asyncSubscribe(com.google.protobuf.ByteString,
+     *                                              com.google.protobuf.ByteString,
+     *                                              PubSubProtocol.SubscriptionOptions,Callback,Object)}
      */
+    @Deprecated
     public void asyncSubscribe(ByteString topic, ByteString subscriberId, CreateOrAttach mode, Callback<Void> callback,
                                Object context);