[GitHub] [spark] imback82 commented on a change in pull request #29127: [SPARK-32327][SQL] Introduce UnresolvedTableOrPermanentView for commands that support a table and permanent view, but not a temporary view

[GitBox <gi...@apache.org>]

imback82 commented on a change in pull request #29127:
URL: https://github.com/apache/spark/pull/29127#discussion_r455567057



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -920,7 +920,7 @@ case class ShowTablePropertiesCommand(table: TableIdentifier, propertyKey: Optio
   override def run(sparkSession: SparkSession): Seq[Row] = {
     val catalog = sparkSession.sessionState.catalog
     if (catalog.isTemporaryTable(table)) {
-      Seq.empty[Row]
+      throw new AnalysisException(s"SHOW TBLPROPERTIES is not allowed on a temporary view: $table")

Review comment:
       This will not be hit if you go thru `SHOW TBLPROPERTIES` command.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org