You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/11/15 13:55:33 UTC
[GitHub] [hive] zabetak opened a new pull request #2790: HIVE-25701: Declare JDBC drivers as runtime & optional dependencies
zabetak opened a new pull request #2790:
URL: https://github.com/apache/hive/pull/2790
### What changes were proposed in this pull request?
1. Use dependency management section for setting version, scope, and optionality of a JDBC driver.
2. Remove download-maven-plugin.
3. Add explicit dependencies to drivers when necessary.
4. Gather JDBC declarations together in dependency management.
### Why are the changes needed?
1. Eliminates the risk to write code which needs JDBC driver classes in order to compile and potentially violate AL2.
2. Unifies the declaration of JDBC drivers making easier to add/remove one if necessary.
3. Removes the need to use download-maven-plugin and other similar workarounds to avoid licensing problems.
4. Simplifies the execution of tests using these drivers since now they are added in the runtime classpath automatically by maven.
5. Projects with dependencies depending on Hive will not inherit any JDBC driver by default.
### Does this PR introduce _any_ user-facing change?
Projects depending on Hive modules with derby must now declare the JDBC driver dependency explicitly.
### How was this patch tested?
1. Run various tests dependent on the presence of JDBC drivers
```
cd standalone-metastore/metastore-server
mvn verify -DskipITests=false -Dtest=nosuch -Dit.test=ITestDerby
mvn verify -DskipITests=false -Dtest=nosuch -Dit.test=ITestPostgres
mvn verify -DskipITests=false -Dtest=nosuch -Dit.test=ITestOracle
mvn verify -DskipITests=false -Dtest=nosuch -Dit.test=ITestMysql
mvn verify -DskipITests=false -Dtest=nosuch -Dit.test=ITestMssql
cd itests/qtest
mvn test -Dtest=TestMiniLlapLocalCliDriver -Dqfile_regex=jdbc_table_with_schema.*
```
2. Ensure JDBC drivers appear as runtime & optional via mvn dependency:tree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak commented on pull request #2790: HIVE-25701: Declare JDBC drivers as runtime & optional dependencies
Posted by GitBox <gi...@apache.org>.
zabetak commented on pull request #2790:
URL: https://github.com/apache/hive/pull/2790#issuecomment-968989384
Thanks for the quick review @kgyrtkirk .
I just pushed another commit (https://github.com/apache/hive/pull/2790/commits/2f66d45088bda27ea906f06c356c6cccbb2da6a8) with further cleanup.
Let's see if everything goes well in CI :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] zabetak closed pull request #2790: HIVE-25701: Declare JDBC drivers as runtime & optional dependencies
Posted by GitBox <gi...@apache.org>.
zabetak closed pull request #2790:
URL: https://github.com/apache/hive/pull/2790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org