You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/06/12 01:24:15 UTC
[GitHub] [incubator-gobblin] autumnust opened a new pull request #3040: [GOBBLIN-1192] Commit suicide if Helix Task creation failed after retry
autumnust opened a new pull request #3040:
URL: https://github.com/apache/incubator-gobblin/pull/3040
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- https://issues.apache.org/jira/browse/GOBBLIN-1192
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
When creating a Helix Task, if creation failed after retrying, will post a event to result in container suicide.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter edited a comment on pull request #3040: [GOBBLIN-1192] Commit suicide if Helix Task creation failed after retry
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3040:
URL: https://github.com/apache/incubator-gobblin/pull/3040#issuecomment-643525522
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=h1) Report
> Merging [#3040](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/93ee79546759d73310fb6f949fcbfc57e232ccd8&el=desc) will **decrease** coverage by `36.50%`.
> The diff coverage is `26.66%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3040 +/- ##
============================================
- Coverage 45.78% 9.27% -36.51%
+ Complexity 9328 1696 -7632
============================================
Files 1956 1957 +1
Lines 74423 74431 +8
Branches 8250 8250
============================================
- Hits 34073 6906 -27167
- Misses 37157 66850 +29693
+ Partials 3193 675 -2518
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/gobblin/cluster/InMemoryWuFailedSingleTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSW5NZW1vcnlXdUZhaWxlZFNpbmdsZVRhc2suamF2YQ==) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [...g/apache/gobblin/cluster/InMemoryWuSingleTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSW5NZW1vcnlXdVNpbmdsZVRhc2suamF2YQ==) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| [...ache/gobblin/cluster/SingleFailInCreationTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlRmFpbEluQ3JlYXRpb25UYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `59.30% <14.28%> (-4.99%)` | `5.00 <0.00> (-1.00)` | |
| [...in/java/org/apache/gobblin/cluster/SingleTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlVGFzay5qYXZh) | `63.38% <60.00%> (-18.98%)` | `8.00 <1.00> (-4.00)` | |
| [...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| [...n/java/org/apache/gobblin/fork/CopyableSchema.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZvcmsvQ29weWFibGVTY2hlbWEuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...java/org/apache/gobblin/stream/ControlMessage.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc3RyZWFtL0NvbnRyb2xNZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...va/org/apache/gobblin/dataset/DatasetResolver.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YXNldC9EYXRhc2V0UmVzb2x2ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...va/org/apache/gobblin/converter/EmptyIterable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbnZlcnRlci9FbXB0eUl0ZXJhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1034 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=footer). Last update [93ee795...c7cf136](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #3040: [GOBBLIN-1192] Commit suicide if Helix Task creation failed after retry
Posted by GitBox <gi...@apache.org>.
sv2000 commented on a change in pull request #3040:
URL: https://github.com/apache/incubator-gobblin/pull/3040#discussion_r439181661
##########
File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixTask.java
##########
@@ -194,6 +195,7 @@ private ContainerHealthCheckFailureEvent createTaskCreationEvent() {
event.addMetadata("helixJobId", this.helixJobId);
Review comment:
Can we align the metadata field names to the ones in HelixTaskEventMetadataGenerator?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter commented on pull request #3040: [GOBBLIN-1192] Commit suicide if Helix Task creation failed after retry
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3040:
URL: https://github.com/apache/incubator-gobblin/pull/3040#issuecomment-643525522
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=h1) Report
> Merging [#3040](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/93ee79546759d73310fb6f949fcbfc57e232ccd8&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3040 +/- ##
============================================
+ Coverage 45.78% 45.79% +0.01%
- Complexity 9328 9329 +1
============================================
Files 1956 1956
Lines 74423 74425 +2
Branches 8250 8250
============================================
+ Hits 34073 34082 +9
+ Misses 37157 37148 -9
- Partials 3193 3195 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `75.58% <85.71%> (+11.29%)` | `7.00 <0.00> (+1.00)` | |
| [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `59.09% <0.00%> (-1.52%)` | `14.00% <0.00%> (-1.00%)` | |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `61.42% <0.00%> (-1.43%)` | `4.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=footer). Last update [93ee795...91f4408](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3040: [GOBBLIN-1192] Commit suicide if Helix Task creation failed after retry
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3040:
URL: https://github.com/apache/incubator-gobblin/pull/3040
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter edited a comment on pull request #3040: [GOBBLIN-1192] Commit suicide if Helix Task creation failed after retry
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3040:
URL: https://github.com/apache/incubator-gobblin/pull/3040#issuecomment-643525522
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=h1) Report
> Merging [#3040](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/93ee79546759d73310fb6f949fcbfc57e232ccd8&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3040 +/- ##
============================================
+ Coverage 45.78% 45.79% +0.01%
- Complexity 9328 9329 +1
============================================
Files 1956 1956
Lines 74423 74425 +2
Branches 8250 8250
============================================
+ Hits 34073 34082 +9
+ Misses 37157 37148 -9
- Partials 3193 3195 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `75.58% <85.71%> (+11.29%)` | `7.00 <0.00> (+1.00)` | |
| [...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh) | `59.09% <0.00%> (-1.52%)` | `14.00% <0.00%> (-1.00%)` | |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3040/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `61.42% <0.00%> (-1.43%)` | `4.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=footer). Last update [93ee795...91f4408](https://codecov.io/gh/apache/incubator-gobblin/pull/3040?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org