You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by ASF Subversion and Git Services <as...@urd.zones.apache.org> on 2014/07/30 12:32:04 UTC
Re: Review Request 20621: CLOUDSTACK-6529: Fixed adding hosts even if any
host addition fails.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20621/#review49094
-----------------------------------------------------------
Commit 25a78acee127e7b195e4508bd8c1740d9fe227ed in cloudstack's branch refs/heads/4.4 from santhosh
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=25a78ac ]
Added fix for CLOUDSTACK-6529
Fixed to continue adding all hosts, even if any addition fails and remove
unused args from host class.
Signed-off-by: santhosh <sa...@gmail.com>
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
(cherry picked from commit 6f3ff068270f48e00531c462de4f7d76395658ff)
Conflicts:
tools/marvin/marvin/deployDataCenter.py
- ASF Subversion and Git Services
On May 23, 2014, 12:39 p.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20621/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 12:39 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Bugs: CLOUDSTACK-6529
> https://issues.apache.org/jira/browse/CLOUDSTACK-6529
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. In deployDataCenter when a host addition fails, it is not continuing further. Added a change, to continue adding all hosts, even if any addition fails. Do a cleanup only when all host addition fails. Tested the changes on local setup
>
> 2. Removed another unwanted arguments from class host which are not part of addHost call.
> 3. Added an exit check based upon correct input file path type.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/configGenerator.py 66609da
> tools/marvin/marvin/deployDataCenter.py 4d8be58
>
> Diff: https://reviews.apache.org/r/20621/diff/
>
>
> Testing
> -------
>
> Tested the changes that it is not breaking existing deployDataCenter.
>
>
> Thanks,
>
> Santhosh Edukulla
>
>