Re: [PR] feat(embedded): Embed Charts using GuestToken similar to SIP-75 [superset]

["jayakrishnankk (via GitHub)" <gi...@apache.org>]

jayakrishnankk commented on code in PR #30076:
URL: https://github.com/apache/superset/pull/30076#discussion_r1803532625


##########
superset-frontend/src/embedded/index.tsx:
##########
@@ -51,22 +51,39 @@ const LazyDashboardPage = lazy(
     ),
 );
 
-const EmbeddedRoute = () => (
-  <Suspense fallback={<Loading />}>
-    <RootContextProviders>
-      <ErrorBoundary>
-        <LazyDashboardPage idOrSlug={bootstrapData.embedded!.dashboard_id} />
-      </ErrorBoundary>
-      <ToastContainer position="top" />
-    </RootContextProviders>
-  </Suspense>
+const LazyChartPage = lazy(
+  () => import(/* webpackChunkName: "Chart" */ 'src/pages/Chart'),
 );
 
+const EmbeddedRoute = () =>
+  bootstrapData.embedded!.dashboard_id ? (

Review Comment:
   This line should be `bootstrapData.embedded ? (`
   Needs a fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org