You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2015/10/20 19:59:02 UTC

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-898: Rename Conjuctio...

GitHub user okram opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/115

    TINKERPOP3-898: Rename ConjuctionP and ConjuctionStep to ConnectiveP and ConnectiveStep

    https://issues.apache.org/jira/browse/TINKERPOP3-898
    
    In logic, "conjunction" implies AND. The general term for both AND and OR is "connective."
    
    * Renamed all `ConjunctionXXX` to `ConnectiveXXX`.
    * This is a breaking change but very internal to TinkerPop steps and given that we are not exposing the "instruction set" paradigm yet, its best this happens now than later.
    * I ran `mvn clean install` and everything built. This does NOT effect docs nor integration testing.
    * I updated the `CHANGELOG.asciidoc`.
    
    I VOTE +1 (binding).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-898

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----
commit 45fc9f261cd0baf1e7ecf817d4dd9d8f14c1e39e
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2015-10-20T17:55:52Z

    Renamed ConjunctionXXX to ConnectiveXXX as that is more resonent with the terminology used in logic, where conjunction assumes and and dijunction or.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-898: Rename Conjuctio...

Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/115#issuecomment-149692157
  
    Vote: +1
    
    Very simple refactoring, nothing to complain about.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-898: Rename Conjuctio...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/115


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: TINKERPOP3-898: Rename Conjuctio...

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/115#issuecomment-149706669
  
    VOTE: +1 (binding)
    
    Ran `mvn clean install` - no problems....you have 3 +1s - time to merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---