You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/03/20 17:08:31 UTC

[GitHub] [nifi] alopresto commented on a change in pull request #4154: NIFI-7271 Make command timeout configurable for ShellUserGroupProvider

alopresto commented on a change in pull request #4154: NIFI-7271 Make command timeout configurable for ShellUserGroupProvider
URL: https://github.com/apache/nifi/pull/4154#discussion_r395775952
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-shell-authorizer/src/main/java/org/apache/nifi/authorization/ShellUserGroupProvider.java
 ##########
 @@ -339,6 +349,26 @@ private long getDelayProperty(AuthorizerConfigurationContext authContext, String
         return syncInterval;
     }
 
+    private long getTimeoutProperty(AuthorizerConfigurationContext authContext, String propertyName, String defaultValue) {
 
 Review comment:
   I like that this logic is encapsulated in a private accessor method. Very clean design. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services