[jira] [Commented] (COLLECTIONS-814) CollectionUtils.removeAll() not throwing proper NullPointerException(NPE) if the first parameter is empty

["Angus C (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COLLECTIONS-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17609060#comment-17609060 ] 

Angus C commented on COLLECTIONS-814:
-------------------------------------

https://github.com/apache/commons-collections/pull/340

> CollectionUtils.removeAll() not throwing proper NullPointerException(NPE) if the first parameter is empty
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: COLLECTIONS-814
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-814
>             Project: Commons Collections
>          Issue Type: Bug
>    Affects Versions: 4.4
>            Reporter: Elia Bertolina
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The CollectionUtils.removeAll(Collection<E> collection, Collection<?> remove) does not throw a NullPointerException(NPE) when the “remove” parameters is null, but only if the “collection” parameter is empty.
> In the documentation it is stated that an NPE will be thrown if any of the parameters is null.
> However, in this test case:
>  
> {code:java}
> public class CollectionUtils_failure_Test {
>     public void test() throws Throwable {
>         LinkedList<InstanceofPredicate> linkedList = new
>         LinkedList<InstanceofPredicate>();
>         try {
>             Collection<InstanceofPredicate> collection =
>             CollectionUtils.removeAll(
>             (Collection<InstanceofPredicate>)linkedList,
>             (Collection<?>) null);
>             org.junit.Assert.fail();
>         } catch (java.lang.NullPointerException e) {
>            //Exception caught and test successful
>         }    
>     }
> } {code}
>  
> This is a special case (first parameter needs to be empty and the second needs to be null) but this behavior is missing in the documentation. While this behavior is somehow correct (removing a null Object from an empty Collection we should obtain an empty Collection) I think throwing an NPE would be more in line with the documentation provided.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)