[GitHub] [dubbo] CrazyHZM commented on a diff in pull request #12118: Support Shutdown Gracefully

["CrazyHZM (via GitHub)" <gi...@apache.org>]

CrazyHZM commented on code in PR #12118:
URL: https://github.com/apache/dubbo/pull/12118#discussion_r1173239805


##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java:
##########
@@ -209,6 +219,51 @@ public void unexport() {
         repository.unregisterProvider(providerModel);
     }
 
+    private void waitForIdle() {

Review Comment:
   Graceful offline also needs to consider that the connection is no longer receiving new requests, and the thread pool has completed all tasks within the specified time. Is it possible to check the number of tasks in some thread pools here?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org