You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "JackieTien97 (via GitHub)" <gi...@apache.org> on 2023/03/29 03:51:42 UTC

[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #9476: [IOTDB-5683] Add special case process for aggregation function Mode

JackieTien97 commented on code in PR #9476:
URL: https://github.com/apache/iotdb/pull/9476#discussion_r1151363666


##########
server/src/main/codegen/templates/ModeAccumulator.ftl:
##########
@@ -96,7 +104,7 @@ public class ${className} implements Accumulator {
 
     // Step of ModeAccumulator is STATIC,
     // countMap only need to record one entry which key is finalResult
-    countMap.put(finalResult.get${type.dataType?cap_first}(0), 0L);
+    countMap.put(finalResult.get${type.dataType?cap_first}(0), new Pair<>(0L, 0L));

Review Comment:
   ```suggestion
       countMap.put(finalResult.get${type.dataType?cap_first}(0), new Pair<>(0L, Long.MIN_VALUE));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org