You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2008/08/12 06:44:44 UTC
[jira] Commented: (HADOOP-3932) Two small improvements to pipes
[ https://issues.apache.org/jira/browse/HADOOP-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621691#action_12621691 ]
Owen O'Malley commented on HADOOP-3932:
---------------------------------------
Can you please regenerate the patch with svn diff as outlined in http://wiki.apache.org/hadoop/HowToContribute?
It looks like you have some whitespace changes that have sneaked into your patch. Please remove them.
> Two small improvements to pipes
> -------------------------------
>
> Key: HADOOP-3932
> URL: https://issues.apache.org/jira/browse/HADOOP-3932
> Project: Hadoop Core
> Issue Type: Improvement
> Components: pipes
> Affects Versions: 0.17.1
> Environment: n/a
> Reporter: Leon Mergen
> Assignee: Leon Mergen
> Attachments: pipes.patch
>
>
> Working with the ..mapred.pipes class a bit today, I found one bug and one possible interface improvement:
> - Application.java in its constructor assumes that DistributedCache.getLocalCacheFiles () always returns non-zero, and returns an array with at least one element -- appropriate checks and exceptions should be thrown here.
> - Submitter.java provides a "submitJob ()" method, yet it acts like it's a runJob method (and also invokes mapred.JobClient.runClient ()) -- it should provide two interface methods, one runJob () and one submitJob (), who act just like the JobClient counterparts.
> Here is the small patch that implements both changes, based on the 0.17.1 release source -- just in case anyone cares for this minor improvement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.