You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "pepness (via GitHub)" <gi...@apache.org> on 2023/04/10 23:00:00 UTC
[GitHub] [netbeans] pepness opened a new pull request, #5804: Use Antlr runtimes from ide.libs
pepness opened a new pull request, #5804:
URL: https://github.com/apache/netbeans/pull/5804
Use antlr runtimes from ide.libs (like go.grammar) instead of downloading again.
NetBeans Testing:
- Verify successful execution of libraries and licenses Ant test
- Verify successful execution of Verify Sigtests
- Verify successful execution of unit tests for modules `rust.grammar`, `libs.antlr3.runtime` and `libs.antlr4.runtime`
- Started NetBeans and ensure the log didn't have any ERROR or new WARNINGS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on a diff in pull request #5804: Use Antlr runtimes from ide.libs
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on code in PR #5804:
URL: https://github.com/apache/netbeans/pull/5804#discussion_r1163213313
##########
rust/rust.grammar/external/binaries-list:
##########
@@ -1,23 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-# The full antlr4 binary, as a build-time dependency (se use it to generate code from the grammar)
-844C603E04AB201B769849EE9D3CCE67BA7A1337 org.antlr:antlr4:4.11.1
Review Comment:
Mmm... we're dropping the ANTLR4 compiler, this is different from the runtime. Let's see if things work now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #5804: Use Antlr runtimes from ide.libs
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #5804:
URL: https://github.com/apache/netbeans/pull/5804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] vieiro commented on pull request #5804: Use Antlr runtimes from ide.libs
Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #5804:
URL: https://github.com/apache/netbeans/pull/5804#issuecomment-1503950224
It seems we're dropping the ANTLR4 compiler (this is a JAR different from the runtime). The ANTLR4 compiler is used to compile grammars at build time.
Let's see if we pass the Rust tests. In order to do that I'll add the "Rust" label and "Lock" and "Unlock" the github conversation, so Rust tests are run. Let's see what happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists