[GitHub] [superset] etr2460 commented on a change in pull request #18201: fix: Build scripts

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #18201:
URL: https://github.com/apache/superset/pull/18201#discussion_r793800616



##########
File path: docs-v2/docusaurus.config.js
##########
@@ -51,11 +51,11 @@ const config = {
             from: '/tutorials.html',
           },
           {
-            to: '/docs/creating-charts-dashboards/first-dashboard',
+            to: '/docs/Creating Charts and Dashboards/creating-your-first-dashboard',

Review comment:
       not 100% sure what the change is here, but it's kinda odd to have spaces in a url. If this is replacing the old docs, then we should also make sure that redirects are setup between old and new urls

##########
File path: docs-v2/docusaurus.config.js
##########
@@ -30,7 +30,7 @@ const config = {
     'Apache Superset is a modern data exploration and visualization platform',
   url: 'https://superset.apache.org',
   baseUrl: '/',
-  onBrokenLinks: 'throw',

Review comment:
       should we change this? throwing if we build docs with broken links seems reasonable to me




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org