You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2010/01/29 13:40:34 UTC
[jira] Created: (DERBY-4529) BlobMemTest and ClobMemTest don't call
super.tearDown()
BlobMemTest and ClobMemTest don't call super.tearDown()
-------------------------------------------------------
Key: DERBY-4529
URL: https://issues.apache.org/jira/browse/DERBY-4529
Project: Derby
Issue Type: Bug
Components: Test
Affects Versions: 10.6.0.0
Reporter: Knut Anders Hatlen
Assignee: Knut Anders Hatlen
Priority: Minor
The tests memory.BlobMemTest and memory.ClobMemTest have a tearDown() method that looks like this:
public void tearDown() throws SQLException {
rollback();
}
They should also call super.tearDown() in order to perform some additional clean-up (like closing of connection and statements). Since the tearDown() method in BaseJDBCTestCase will also take care of calling rollback() on the connection, there's not actually any need for a specialized tearDown() method in these tests, so I suggest we just remove the methods and let the classes inherit the method from BaseJDBCTestCase.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4529) BlobMemTest and ClobMemTest don't call
super.tearDown()
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen updated DERBY-4529:
--------------------------------------
Attachment: tearDown.diff
The attached patch removes the two tearDown() methods.
> BlobMemTest and ClobMemTest don't call super.tearDown()
> -------------------------------------------------------
>
> Key: DERBY-4529
> URL: https://issues.apache.org/jira/browse/DERBY-4529
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.6.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Attachments: tearDown.diff
>
>
> The tests memory.BlobMemTest and memory.ClobMemTest have a tearDown() method that looks like this:
> public void tearDown() throws SQLException {
> rollback();
> }
> They should also call super.tearDown() in order to perform some additional clean-up (like closing of connection and statements). Since the tearDown() method in BaseJDBCTestCase will also take care of calling rollback() on the connection, there's not actually any need for a specialized tearDown() method in these tests, so I suggest we just remove the methods and let the classes inherit the method from BaseJDBCTestCase.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-4529) BlobMemTest and ClobMemTest don't call
super.tearDown()
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut Anders Hatlen closed DERBY-4529.
-------------------------------------
Resolution: Fixed
Fix Version/s: 10.6.0.0
Committed revision 904483.
> BlobMemTest and ClobMemTest don't call super.tearDown()
> -------------------------------------------------------
>
> Key: DERBY-4529
> URL: https://issues.apache.org/jira/browse/DERBY-4529
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.6.0.0
> Reporter: Knut Anders Hatlen
> Assignee: Knut Anders Hatlen
> Priority: Minor
> Fix For: 10.6.0.0
>
> Attachments: tearDown.diff
>
>
> The tests memory.BlobMemTest and memory.ClobMemTest have a tearDown() method that looks like this:
> public void tearDown() throws SQLException {
> rollback();
> }
> They should also call super.tearDown() in order to perform some additional clean-up (like closing of connection and statements). Since the tearDown() method in BaseJDBCTestCase will also take care of calling rollback() on the connection, there's not actually any need for a specialized tearDown() method in these tests, so I suggest we just remove the methods and let the classes inherit the method from BaseJDBCTestCase.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.