[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4410: ARTEMIS-4213 doc update added some Broker Properties reference and added s…

["gemmellr (via GitHub)" <gi...@apache.org>]

gemmellr commented on code in PR #4410:
URL: https://github.com/apache/activemq-artemis/pull/4410#discussion_r1155682921


##########
docs/user-manual/en/configuration-index.md:
##########
@@ -481,3 +484,285 @@ Name | Description | Default
 [password](amqp-broker-connections.md#amqp-server-connections) | Broker authentication password (optional) | n/a
 [reconnect-attempts](amqp-broker-connections.md#amqp-server-connections) | How many attempts should be made to reconnect after failure. | -1 (infinite)
 [auto-start](amqp-broker-connections.md#amqp-server-connections) | Broker connection starts automatically with broker | true
+
+
+## Broker Properties Reference

Review Comment:
   This perhaps do with a small intro like the earlier sections, maybe a reference to the doc on how to actually use these properties and how their naming convention relates to the XML config and code.
   
   Would also be worth a warning that the property values set will override existing XML config, which can in turn already have overridden any 'real code default' (which the XML does so out of the box for some things), meaning some of the below listed Default values may not actually match the no-property-defined 'effective-default' at all, since they are defined differently in the xml config they use/get (either by them previously...or right out of the box in the 'default xml config' in some cases).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org