You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/06/03 01:15:37 UTC
Review Request 34962: Moved NoopResourceEstimator to a separate file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/
-----------------------------------------------------------
Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone.
Repository: mesos
Description
-------
Moved NoopResourceEstimator to a separate file.
As we're going to introduce more resource estimators in the code base, it makes sense to put them into a directory.
Diffs
-----
src/Makefile.am 081185bb28fa58c8fe0b1ffa8db6599def56e85b
src/examples/test_resource_estimator_module.cpp df85978f2beeccd0cccd893f13a8a0eeacd15e23
src/local/local.cpp 84f73e21e66e7a654b6b09f6a57a70a1ccc34b40
src/slave/main.cpp e3a45f4dfa0c8cc5d28d795f42bdc8cd14b7b10d
src/slave/resource_estimator.hpp 717804d65072a55e6c2bead14ab17be7fec57077
src/slave/resource_estimator.cpp a67640c3878c5707b8ef39c0750711c619680a39
src/slave/resource_estimator/noop.cpp PRE-CREATION
src/tests/cluster.hpp 7370c77de68d3a13340a69f6e794d97306d4bbb6
Diff: https://reviews.apache.org/r/34962/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 34962: Moved NoopResourceEstimator to a separate
file.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/#review86332
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34962]
All tests passed.
- Mesos ReviewBot
On June 2, 2015, 11:15 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34962/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 11:15 p.m.)
>
>
> Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved NoopResourceEstimator to a separate file.
>
> As we're going to introduce more resource estimators in the code base, it makes sense to put them into a directory.
>
>
> Diffs
> -----
>
> src/Makefile.am 081185bb28fa58c8fe0b1ffa8db6599def56e85b
> src/examples/test_resource_estimator_module.cpp df85978f2beeccd0cccd893f13a8a0eeacd15e23
> src/local/local.cpp 84f73e21e66e7a654b6b09f6a57a70a1ccc34b40
> src/slave/main.cpp e3a45f4dfa0c8cc5d28d795f42bdc8cd14b7b10d
> src/slave/resource_estimator.hpp 717804d65072a55e6c2bead14ab17be7fec57077
> src/slave/resource_estimator.cpp a67640c3878c5707b8ef39c0750711c619680a39
> src/slave/resource_estimator/noop.cpp PRE-CREATION
> src/tests/cluster.hpp 7370c77de68d3a13340a69f6e794d97306d4bbb6
>
> Diff: https://reviews.apache.org/r/34962/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 34962: Moved NoopResourceEstimator to a separate
file.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/#review86340
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On June 3, 2015, 12:11 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34962/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 12:11 a.m.)
>
>
> Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved NoopResourceEstimator to a separate file.
>
> As we're going to introduce more resource estimators in the code base, it makes sense to put them into a directory.
>
>
> Diffs
> -----
>
> src/Makefile.am f045b89e8590c4775b21980bedff14cc27d31bfb
> src/examples/test_resource_estimator_module.cpp df85978f2beeccd0cccd893f13a8a0eeacd15e23
> src/local/local.cpp 84f73e21e66e7a654b6b09f6a57a70a1ccc34b40
> src/slave/main.cpp e3a45f4dfa0c8cc5d28d795f42bdc8cd14b7b10d
> src/slave/resource_estimator.hpp 717804d65072a55e6c2bead14ab17be7fec57077
> src/slave/resource_estimator.cpp a67640c3878c5707b8ef39c0750711c619680a39
> src/slave/resource_estimators/noop.cpp PRE-CREATION
> src/tests/cluster.hpp 7370c77de68d3a13340a69f6e794d97306d4bbb6
>
> Diff: https://reviews.apache.org/r/34962/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 34962: Moved NoopResourceEstimator to a separate
file.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/
-----------------------------------------------------------
(Updated June 3, 2015, 12:11 a.m.)
Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone.
Changes
-------
s/resource_estimator/resource_estimators/
Repository: mesos
Description
-------
Moved NoopResourceEstimator to a separate file.
As we're going to introduce more resource estimators in the code base, it makes sense to put them into a directory.
Diffs (updated)
-----
src/Makefile.am f045b89e8590c4775b21980bedff14cc27d31bfb
src/examples/test_resource_estimator_module.cpp df85978f2beeccd0cccd893f13a8a0eeacd15e23
src/local/local.cpp 84f73e21e66e7a654b6b09f6a57a70a1ccc34b40
src/slave/main.cpp e3a45f4dfa0c8cc5d28d795f42bdc8cd14b7b10d
src/slave/resource_estimator.hpp 717804d65072a55e6c2bead14ab17be7fec57077
src/slave/resource_estimator.cpp a67640c3878c5707b8ef39c0750711c619680a39
src/slave/resource_estimators/noop.cpp PRE-CREATION
src/tests/cluster.hpp 7370c77de68d3a13340a69f6e794d97306d4bbb6
Diff: https://reviews.apache.org/r/34962/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 34962: Moved NoopResourceEstimator to a separate
file.
Posted by Jie Yu <yu...@gmail.com>.
> On June 2, 2015, 11:24 p.m., Niklas Nielsen wrote:
> > Should we name the 'resource_estimator' directory 'resource_estimators' like we name the directory isolators?
> >
> > I am fine with either; just wanted to get a feel for what pattern we want to go with (the containerizer directory is in singular)
> >
> > Otherwise, LGTM
Hum, seems that we use plural more often than singular (src/tests, src/credentials, src/files, etc.)
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/#review86315
-----------------------------------------------------------
On June 2, 2015, 11:15 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34962/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 11:15 p.m.)
>
>
> Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved NoopResourceEstimator to a separate file.
>
> As we're going to introduce more resource estimators in the code base, it makes sense to put them into a directory.
>
>
> Diffs
> -----
>
> src/Makefile.am 081185bb28fa58c8fe0b1ffa8db6599def56e85b
> src/examples/test_resource_estimator_module.cpp df85978f2beeccd0cccd893f13a8a0eeacd15e23
> src/local/local.cpp 84f73e21e66e7a654b6b09f6a57a70a1ccc34b40
> src/slave/main.cpp e3a45f4dfa0c8cc5d28d795f42bdc8cd14b7b10d
> src/slave/resource_estimator.hpp 717804d65072a55e6c2bead14ab17be7fec57077
> src/slave/resource_estimator.cpp a67640c3878c5707b8ef39c0750711c619680a39
> src/slave/resource_estimator/noop.cpp PRE-CREATION
> src/tests/cluster.hpp 7370c77de68d3a13340a69f6e794d97306d4bbb6
>
> Diff: https://reviews.apache.org/r/34962/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 34962: Moved NoopResourceEstimator to a separate
file.
Posted by Jie Yu <yu...@gmail.com>.
> On June 2, 2015, 11:24 p.m., Niklas Nielsen wrote:
> > Should we name the 'resource_estimator' directory 'resource_estimators' like we name the directory isolators?
> >
> > I am fine with either; just wanted to get a feel for what pattern we want to go with (the containerizer directory is in singular)
> >
> > Otherwise, LGTM
>
> Jie Yu wrote:
> Hum, seems that we use plural more often than singular (src/tests, src/credentials, src/files, etc.)
OK, I think 'containerizer' is a legacy issue (there was only one containerizer at that time)
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/#review86315
-----------------------------------------------------------
On June 2, 2015, 11:15 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34962/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 11:15 p.m.)
>
>
> Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved NoopResourceEstimator to a separate file.
>
> As we're going to introduce more resource estimators in the code base, it makes sense to put them into a directory.
>
>
> Diffs
> -----
>
> src/Makefile.am 081185bb28fa58c8fe0b1ffa8db6599def56e85b
> src/examples/test_resource_estimator_module.cpp df85978f2beeccd0cccd893f13a8a0eeacd15e23
> src/local/local.cpp 84f73e21e66e7a654b6b09f6a57a70a1ccc34b40
> src/slave/main.cpp e3a45f4dfa0c8cc5d28d795f42bdc8cd14b7b10d
> src/slave/resource_estimator.hpp 717804d65072a55e6c2bead14ab17be7fec57077
> src/slave/resource_estimator.cpp a67640c3878c5707b8ef39c0750711c619680a39
> src/slave/resource_estimator/noop.cpp PRE-CREATION
> src/tests/cluster.hpp 7370c77de68d3a13340a69f6e794d97306d4bbb6
>
> Diff: https://reviews.apache.org/r/34962/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 34962: Moved NoopResourceEstimator to a separate
file.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/#review86315
-----------------------------------------------------------
Should we name the 'resource_estimator' directory 'resource_estimators' like we name the directory isolators?
I am fine with either; just wanted to get a feel for what pattern we want to go with (the containerizer directory is in singular)
Otherwise, LGTM
- Niklas Nielsen
On June 2, 2015, 4:15 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34962/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 4:15 p.m.)
>
>
> Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved NoopResourceEstimator to a separate file.
>
> As we're going to introduce more resource estimators in the code base, it makes sense to put them into a directory.
>
>
> Diffs
> -----
>
> src/Makefile.am 081185bb28fa58c8fe0b1ffa8db6599def56e85b
> src/examples/test_resource_estimator_module.cpp df85978f2beeccd0cccd893f13a8a0eeacd15e23
> src/local/local.cpp 84f73e21e66e7a654b6b09f6a57a70a1ccc34b40
> src/slave/main.cpp e3a45f4dfa0c8cc5d28d795f42bdc8cd14b7b10d
> src/slave/resource_estimator.hpp 717804d65072a55e6c2bead14ab17be7fec57077
> src/slave/resource_estimator.cpp a67640c3878c5707b8ef39c0750711c619680a39
> src/slave/resource_estimator/noop.cpp PRE-CREATION
> src/tests/cluster.hpp 7370c77de68d3a13340a69f6e794d97306d4bbb6
>
> Diff: https://reviews.apache.org/r/34962/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 34962: Moved NoopResourceEstimator to a separate
file.
Posted by Bartek Plotka <bw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34962/#review86323
-----------------------------------------------------------
Ship it!
Ship It!
- Bartek Plotka
On June 2, 2015, 11:15 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34962/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 11:15 p.m.)
>
>
> Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved NoopResourceEstimator to a separate file.
>
> As we're going to introduce more resource estimators in the code base, it makes sense to put them into a directory.
>
>
> Diffs
> -----
>
> src/Makefile.am 081185bb28fa58c8fe0b1ffa8db6599def56e85b
> src/examples/test_resource_estimator_module.cpp df85978f2beeccd0cccd893f13a8a0eeacd15e23
> src/local/local.cpp 84f73e21e66e7a654b6b09f6a57a70a1ccc34b40
> src/slave/main.cpp e3a45f4dfa0c8cc5d28d795f42bdc8cd14b7b10d
> src/slave/resource_estimator.hpp 717804d65072a55e6c2bead14ab17be7fec57077
> src/slave/resource_estimator.cpp a67640c3878c5707b8ef39c0750711c619680a39
> src/slave/resource_estimator/noop.cpp PRE-CREATION
> src/tests/cluster.hpp 7370c77de68d3a13340a69f6e794d97306d4bbb6
>
> Diff: https://reviews.apache.org/r/34962/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>