You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by GitBox <gi...@apache.org> on 2021/02/04 03:27:45 UTC
[GitHub] [hawq] chiyang10000 opened a new pull request #1505: HAWQ-1782. Fix failed to read EXTERNAL TABLE of GPFDIST protocol
chiyang10000 opened a new pull request #1505:
URL: https://github.com/apache/hawq/pull/1505
- revise CREATE EXTERNAL TABLE default to READABLE EXTERNAL TABLE
- fix read from EXTERNAL TABLE of GPFDIST protocol
The documented behaviour of CREATE EXTERNAL TABLE indicates a READABLE
TABLE but used to be violated.
Referring to https://curl.se/libcurl/c/curl_multi_fdset.html,
```
If no file descriptors are set by libcurl, max_fd will contain -1 when
this function returns. Otherwise it will contain the highest descriptor
number libcurl set. When libcurl returns -1 in max_fd, it is because
libcurl currently does something that isn't possible for your
application to monitor with a socket and unfortunately you can then not
know exactly when the current action is completed using select(). You
then need to wait a while before you proceed and call curl_multi_perform
anyway. How long to wait? Unless curl_multi_timeout gives you a lower
number, we suggest 100 milliseconds or so, but you may want to test it
out in your own particular conditions to find a suitable value.
```
it is not an error of `max_fd == -1`. Moreover, the situation of
`max_fd == -1` seems common on macOS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hawq] huor merged pull request #1505: HAWQ-1782. Fix failed to read EXTERNAL TABLE of GPFDIST protocol
Posted by GitBox <gi...@apache.org>.
huor merged pull request #1505:
URL: https://github.com/apache/hawq/pull/1505
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hawq] huor commented on pull request #1505: HAWQ-1782. Fix failed to read EXTERNAL TABLE of GPFDIST protocol
Posted by GitBox <gi...@apache.org>.
huor commented on pull request #1505:
URL: https://github.com/apache/hawq/pull/1505#issuecomment-773179514
+1 LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hawq] huor merged pull request #1505: HAWQ-1782. Fix failed to read EXTERNAL TABLE of GPFDIST protocol
Posted by GitBox <gi...@apache.org>.
huor merged pull request #1505:
URL: https://github.com/apache/hawq/pull/1505
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hawq] huor commented on pull request #1505: HAWQ-1782. Fix failed to read EXTERNAL TABLE of GPFDIST protocol
Posted by GitBox <gi...@apache.org>.
huor commented on pull request #1505:
URL: https://github.com/apache/hawq/pull/1505#issuecomment-773179514
+1 LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org