[GitHub] [dolphinscheduler] fuchanghai commented on a diff in pull request #13680: [improve-#13665] improve datax parser if sql contain *

["fuchanghai (via GitHub)" <gi...@apache.org>]

fuchanghai commented on code in PR #13680:
URL: https://github.com/apache/dolphinscheduler/pull/13680#discussion_r1127293369


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTask.java:
##########
@@ -538,6 +543,11 @@ private String[] tryGrammaticalAnalysisSqlColumnNames(DbType dbType, String sql)
                             String.format("grammatical analysis sql column [ %s ] failed", item));
                 }
 
+                if (SELECT_ALL_CHARACTER.equals(item.toString())) {
+                    log.info("sql contain *,grammatical analysis sql failed");

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org