[jira] [Commented] (RYA-224) Rya Fluo Application Visibility Join Bug

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RYA-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15688093#comment-15688093 ] 

ASF GitHub Bot commented on RYA-224:
------------------------------------

GitHub user meiercaleb opened a pull request:

    https://github.com/apache/incubator-rya/pull/123

    RYA-224 Fluo Visibility Join Bug Fix

    <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
    
      http://www.apache.org/licenses/LICENSE-2.0
    
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
    ## Description
    >What Changed?
    [org.apache.rya.indexing.pcj.fluo.app.JoinResultUpdater was changed and test was added]
    
    ### Tests
    >Test added to test if Fluo Visibility Join Bug was resolved
    [StreamingTestIT in rya.pcj.fluo.integration written to test if appropriate number of PCJ results generated by Fluo when visibilitities added to triples]
    
    ### Links
    [Jira](https://issues.apache.org/jira/browse/RYA-224)
    
    ### Checklist
    - [ ] Code Review
    - [X] Squash Commits
    
    #### People To Reivew
    [Aaron Mihalik, Puja Valiyil]
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/meiercaleb/incubator-rya RYA-224

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rya/pull/123.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #123
    
----
commit e5b315f0bcb4a1ec4aba26a258d26c3a42ace960
Author: Caleb Meier <me...@gmail.com>
Date:   2016-11-22T16:39:09Z

    RYA-224 Fluo Visibility Join Bug Fix

----


> Rya Fluo Application Visibility Join Bug
> ----------------------------------------
>
>                 Key: RYA-224
>                 URL: https://issues.apache.org/jira/browse/RYA-224
>             Project: Rya
>          Issue Type: Bug
>    Affects Versions: 3.2.10
>            Reporter: Caleb Meier
>            Assignee: Caleb Meier
>             Fix For: 3.2.10
>
>
> There is a bug in how the Rya Fluo application processes joins for BindingSet results with visibilities.  When a new BindingSet join result is processed by the JoinObserver for a given node, it scans for results associated with the sibling node.  When the triggering BindingSet has a visibility, there is currently a bug with how the scan prefix is formed to scan the sibling results.  The visibility is incorrectly added to the String to form the prefix, leading to missed results in certain situations.  Line 153 in JoinResultUpdater needs to be changed to remedy this problem.  In particular, the "childBindingSetString" formed on that line needs to be split on the delimiter "\u0001" to remove the visibility appended to that String by the VisibilityBindingSetStringConverter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)