[GitHub] [kafka] ijuma commented on a change in pull request #8672: KAFKA-10002; Improve performances of StopReplicaRequest with large number of partitions to be deleted

[GitBox <gi...@apache.org>]

ijuma commented on a change in pull request #8672:
URL: https://github.com/apache/kafka/pull/8672#discussion_r426083581



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -324,8 +324,17 @@ class ReplicaManager(val config: KafkaConfig,
       brokerTopicStats.removeMetrics(topic)
   }
 
-  def stopReplica(topicPartition: TopicPartition, deletePartition: Boolean): Unit  = {
+  def stopReplica(topicPartition: TopicPartition,
+                  deletePartition: Boolean,
+                  logDirs: mutable.Set[File]): Unit  = {
     if (deletePartition) {
+      val log = logManager.getLog(topicPartition)
+      val futureLog = logManager.getLog(topicPartition, isFuture = true)
+
+      // Collect log dirs ofr the partition for future checkpointing

Review comment:
       Nit: typo `ofr`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org