Re: [PR] #2701 - TcpTransport: fix socket.* options [activemq]

["mattrpav (via GitHub)" <gi...@apache.org>]

mattrpav commented on code in PR #2702:
URL: https://github.com/apache/activemq/pull/2702#discussion_r4318323178


##########
activemq-client/src/main/java/org/apache/activemq/transport/tcp/TcpTransport.java:
##########
@@ -65,6 +65,7 @@ public class TcpTransport extends TransportThreadSupport implements Transport, S
     protected int connectionTimeout = 30000;
     protected int soTimeout;
     protected int socketBufferSize = 64 * 1024;
+    private boolean socketBufferSizeSet;

Review Comment:
   1. flip this to protected to match the other fields. 
   2. add volatile keyword. 
   3. I don't love the suffix 'Set' as it collides with 'setters'. I think we have another naming convention term for tracking when a value is specified.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact