You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by knusbaum <gi...@git.apache.org> on 2017/04/03 15:53:06 UTC
[GitHub] storm pull request #2041: STORM-2452: Storm Metric classes are not thread sa...
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/2041
STORM-2452: Storm Metric classes are not thread safe
Synchronizing metrics methods
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-2452
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2041.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2041
----
commit f02845f1314e2e7b21f1d5daf3918f2b00c96467
Author: Kyle Nusbaum <kn...@yahoo-inc.com>
Date: 2017-04-03T15:47:50Z
Synchronizing metrics methods
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2041: STORM-2452: Storm Metric classes are not thread safe
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2041
I think thread-unsafety of metrics is by design. They're guaranteed to be called only a thread at once, so unless we get or update the value on other than Spout or Bolt's event thread, they should be safe. Updating them is occurred from critical path, and metrics doesn't need to have synchronization overhead with current design.
Btw, thread-unsafety on metrics is why I gave up metrics aggregation for worker side. Instead of struggling about metrics more, I'm just waiting for Metrics V2.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2041: STORM-2452: Storm Metric classes are not thread safe
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2041
Please do some benchmark and check performance regression, and please let me know if it doesn't hurt performance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2041: STORM-2452: Storm Metric classes are not thread sa...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum closed the pull request at:
https://github.com/apache/storm/pull/2041
---