[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #795: HUDI-171 delete tmp file after split merge failure

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #795: HUDI-171 delete tmp file after split merge failure
URL: https://github.com/apache/incubator-hudi/pull/795#discussion_r305343925
 
 

 ##########
 File path: hoodie-common/src/main/java/com/uber/hoodie/common/util/collection/DiskBasedMap.java
 ##########
 @@ -106,7 +106,16 @@ private void initFile(File writeOnlyFileHandle) throws IOException {
     if (!writeOnlyFileHandle.getParentFile().exists()) {
       writeOnlyFileHandle.getParentFile().mkdir();
     }
-    writeOnlyFileHandle.createNewFile();
+    // create the file
+    try {
+      writeOnlyFileHandle.createNewFile();
 
 Review comment:
   Not sure even the shutdown hook is fool proof here.. it wont be called if the jvm is kill -9ed by YARN for e.g   can we look into registering each file we create for deleteOnExit()? 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services