[GitHub] [druid] kfaraz commented on pull request #11889: Ensure backward compatibility of multi dimension partitioning

[GitBox <gi...@apache.org>]

kfaraz commented on pull request #11889:
URL: https://github.com/apache/druid/pull/11889#issuecomment-963847196


   > Generally looks good to me. If there's one comment, given that this is a backwards compat change, I think there could be value in some tests that prove JSON deserialization "works" by starting with a map and using an ObjectMapper to convert that to the object that we expect.
   
   Thanks for the review, @cheddar.
   I can add a test that serializes the return value of the method `getSerializableObject()` and then deserializes it back to get the original object. Would that suffice?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org