You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by sebb <se...@gmail.com> on 2013/07/31 01:01:18 UTC

Re: svn commit: r1508646 - /jmeter/trunk/bin/testfiles/GuiTest231.jmx

On 30 July 2013 22:43,  <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Tue Jul 30 21:43:00 2013
> New Revision: 1508646
>
> URL: http://svn.apache.org/r1508646
> Log:
> Bug 53480 - Add Kerberos support to Http Sampler (HttpClient4)
> Fix Test Plan to add new column
> Bugzilla Id: 53480

-1

As per previous comment; this is wrong - the whole point of the older
test plans is to ensure backwards compatibility.

> Modified:
>     jmeter/trunk/bin/testfiles/GuiTest231.jmx
>
> Modified: jmeter/trunk/bin/testfiles/GuiTest231.jmx
> URL: http://svn.apache.org/viewvc/jmeter/trunk/bin/testfiles/GuiTest231.jmx?rev=1508646&r1=1508645&r2=1508646&view=diff
> ==============================================================================
> --- jmeter/trunk/bin/testfiles/GuiTest231.jmx (original)
> +++ jmeter/trunk/bin/testfiles/GuiTest231.jmx Tue Jul 30 21:43:00 2013
> @@ -167,6 +167,7 @@
>                  <stringProp name="Authorization.password">pass</stringProp>
>                  <stringProp name="Authorization.domain">domain</stringProp>
>                  <stringProp name="Authorization.realm">realm</stringProp>
> +                <stringProp name="Authorization.mechanism">BASIC_DIGEST</stringProp>
>                </elementProp>
>              </collectionProp>
>            </AuthManager>
>
>

Re: svn commit: r1508646 - /jmeter/trunk/bin/testfiles/GuiTest231.jmx

Posted by sebb <se...@gmail.com>.
On 31 July 2013 17:11, Philippe Mouawad <ph...@gmail.com> wrote:
> Hello sebb,
> Thanks for spotting it.
> I have fixed it.
>
> By the way I think GuiTest.jmx is missing new components like MongoDB
> related ones, KeystoreConfig.

No, I think these belong in the appropriate GenTestmnn.jmx

> Also these tests are not very clear regarding their purpose , is there some
> documentation somewhere ?

See TestSaveService.java

> Thanks.
>
> On Wed, Jul 31, 2013 at 1:01 AM, sebb <sebbaz@gmail.com <javascript:_e({},
> 'cvml', 'sebbaz@gmail.com');>> wrote:
>
>> On 30 July 2013 22:43,  <pmouawad@apache.org <javascript:_e({}, 'cvml',
>> 'pmouawad@apache.org');>> wrote:
>> > Author: pmouawad
>> > Date: Tue Jul 30 21:43:00 2013
>> > New Revision: 1508646
>> >
>> > URL: http://svn.apache.org/r1508646
>> > Log:
>> > Bug 53480 - Add Kerberos support to Http Sampler (HttpClient4)
>> > Fix Test Plan to add new column
>> > Bugzilla Id: 53480
>>
>> -1
>>
>> As per previous comment; this is wrong - the whole point of the older
>> test plans is to ensure backwards compatibility.
>>
>> > Modified:
>> >     jmeter/trunk/bin/testfiles/GuiTest231.jmx
>> >
>> > Modified: jmeter/trunk/bin/testfiles/GuiTest231.jmx
>> > URL:
>> http://svn.apache.org/viewvc/jmeter/trunk/bin/testfiles/GuiTest231.jmx?rev=1508646&r1=1508645&r2=1508646&view=diff
>> >
>> ==============================================================================
>> > --- jmeter/trunk/bin/testfiles/GuiTest231.jmx (original)
>> > +++ jmeter/trunk/bin/testfiles/GuiTest231.jmx Tue Jul 30 21:43:00 2013
>> > @@ -167,6 +167,7 @@
>> >                  <stringProp
>> name="Authorization.password">pass</stringProp>
>> >                  <stringProp
>> name="Authorization.domain">domain</stringProp>
>> >                  <stringProp
>> name="Authorization.realm">realm</stringProp>
>> > +                <stringProp
>> name="Authorization.mechanism">BASIC_DIGEST</stringProp>
>> >                </elementProp>
>> >              </collectionProp>
>> >            </AuthManager>
>> >
>> >
>>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.
>
>
>
>
> --
> Cordialement.
> Philippe Mouawad.

svn commit: r1508646 - /jmeter/trunk/bin/testfiles/GuiTest231.jmx

Posted by Philippe Mouawad <ph...@gmail.com>.
Hello sebb,
Thanks for spotting it.
I have fixed it.

By the way I think GuiTest.jmx is missing new components like MongoDB
related ones, KeystoreConfig.

Also these tests are not very clear regarding their purpose , is there some
documentation somewhere ?

Thanks.

On Wed, Jul 31, 2013 at 1:01 AM, sebb <sebbaz@gmail.com <javascript:_e({},
'cvml', 'sebbaz@gmail.com');>> wrote:

> On 30 July 2013 22:43,  <pmouawad@apache.org <javascript:_e({}, 'cvml',
> 'pmouawad@apache.org');>> wrote:
> > Author: pmouawad
> > Date: Tue Jul 30 21:43:00 2013
> > New Revision: 1508646
> >
> > URL: http://svn.apache.org/r1508646
> > Log:
> > Bug 53480 - Add Kerberos support to Http Sampler (HttpClient4)
> > Fix Test Plan to add new column
> > Bugzilla Id: 53480
>
> -1
>
> As per previous comment; this is wrong - the whole point of the older
> test plans is to ensure backwards compatibility.
>
> > Modified:
> >     jmeter/trunk/bin/testfiles/GuiTest231.jmx
> >
> > Modified: jmeter/trunk/bin/testfiles/GuiTest231.jmx
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/bin/testfiles/GuiTest231.jmx?rev=1508646&r1=1508645&r2=1508646&view=diff
> >
> ==============================================================================
> > --- jmeter/trunk/bin/testfiles/GuiTest231.jmx (original)
> > +++ jmeter/trunk/bin/testfiles/GuiTest231.jmx Tue Jul 30 21:43:00 2013
> > @@ -167,6 +167,7 @@
> >                  <stringProp
> name="Authorization.password">pass</stringProp>
> >                  <stringProp
> name="Authorization.domain">domain</stringProp>
> >                  <stringProp
> name="Authorization.realm">realm</stringProp>
> > +                <stringProp
> name="Authorization.mechanism">BASIC_DIGEST</stringProp>
> >                </elementProp>
> >              </collectionProp>
> >            </AuthManager>
> >
> >
>



-- 
Cordialement.
Philippe Mouawad.




-- 
Cordialement.
Philippe Mouawad.