You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2016/10/26 17:43:41 UTC
[GitHub] spark pull request #15646: [SPARK-13747][SQL] Fix concurrent executions in F...
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/15646
[SPARK-13747][SQL] Fix concurrent executions in ForkJoinPool for SQL (branch 2.0)
## What changes were proposed in this pull request?
Backport #15520 to 2.0.
## How was this patch tested?
Jenkins
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark SPARK-13747-2.0
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15646.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15646
----
commit eba011aea147f8eb6eb50dd380512167e48e4624
Author: Shixiong Zhu <sh...@databricks.com>
Date: 2016-10-26T17:36:36Z
[SPARK-13747][SQL] Fix concurrent executions in ForkJoinPool for SQL
Calling `Await.result` will allow other tasks to be run on the same thread when using ForkJoinPool. However, SQL uses a `ThreadLocal` execution id to trace Spark jobs launched by a query, which doesn't work perfectly in ForkJoinPool.
This PR just uses `Awaitable.result` instead to prevent ForkJoinPool from running other tasks in the current waiting thread.
Jenkins
Author: Shixiong Zhu <sh...@databricks.com>
Closes #15520 from zsxwing/SPARK-13747.
(cherry picked from commit 7ac70e7ba8d610a45c21a70dc28e4c989c19451b)
Signed-off-by: Shixiong Zhu <sh...@databricks.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15646: [SPARK-13747][SQL] Fix concurrent executions in ForkJoin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15646
**[Test build #67591 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67591/consoleFull)** for PR 15646 at commit [`eba011a`](https://github.com/apache/spark/commit/eba011aea147f8eb6eb50dd380512167e48e4624).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15646: [SPARK-13747][SQL] Fix concurrent executions in ForkJoin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15646
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67591/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15646: [SPARK-13747][SQL] Fix concurrent executions in ForkJoin...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15646
**[Test build #67591 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67591/consoleFull)** for PR 15646 at commit [`eba011a`](https://github.com/apache/spark/commit/eba011aea147f8eb6eb50dd380512167e48e4624).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15646: [SPARK-13747][SQL] Fix concurrent executions in ForkJoin...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15646
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15646: [SPARK-13747][SQL] Fix concurrent executions in ForkJoin...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/15646
Merging to 2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15646: [SPARK-13747][SQL] Fix concurrent executions in F...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing closed the pull request at:
https://github.com/apache/spark/pull/15646
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org