You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/13 20:08:26 UTC
[GitHub] [arrow-datafusion] andygrove opened a new issue, #2227: Add unit test for case-sensitive SQL identifiers
andygrove opened a new issue, #2227:
URL: https://github.com/apache/arrow-datafusion/issues/2227
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
PR introduced a regression in case-sensitive comparisons of identifiers but did not cause any test failures, showing that we have a gap in test coverage.
**Describe the solution you'd like**
Implement a unit test based on the examples in the PR that would have caught the regression.
**Describe alternatives you've considered**
None
**Additional context**
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yjshen closed issue #2227: Add unit test for case-sensitive SQL identifiers
Posted by GitBox <gi...@apache.org>.
yjshen closed issue #2227: Add unit test for case-sensitive SQL identifiers
URL: https://github.com/apache/arrow-datafusion/issues/2227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #2227: Add unit test for case-sensitive SQL identifiers
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #2227:
URL: https://github.com/apache/arrow-datafusion/issues/2227#issuecomment-1099623413
And to be clear, the point is to add an **error** test showing that the query errors when incorrect capitalization is used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on issue #2227: Add unit test for case-sensitive SQL identifiers
Posted by GitBox <gi...@apache.org>.
andygrove commented on issue #2227:
URL: https://github.com/apache/arrow-datafusion/issues/2227#issuecomment-1099542832
> Note we didn't merge #2211 yet (so technically I don't think we added a regression yet)
Good point. I updated the description to say *would have*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #2227: Add unit test for case-sensitive SQL identifiers
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #2227:
URL: https://github.com/apache/arrow-datafusion/issues/2227#issuecomment-1098485238
Note we didn't merge https://github.com/apache/arrow-datafusion/pull/2211 yet (so technically I don't think we added a regression yet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org