You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/10/05 06:18:38 UTC
[GitHub] [orc] dongjoon-hyun commented on a change in pull request #548: ORC-670. RecordReaderImpl.findColumns should respect orc.schema.evolution.case.sensitive
dongjoon-hyun commented on a change in pull request #548:
URL: https://github.com/apache/orc/pull/548#discussion_r499364939
##########
File path: java/core/src/test/org/apache/orc/impl/TestRecordReaderImpl.java
##########
@@ -112,6 +112,16 @@ public void testFindColumn() throws Exception {
assertEquals(3, RecordReaderImpl.findColumns(evo, "e"));
}
+ @Test
+ public void testFindColumnCaseInsensitively() throws Exception {
Review comment:
This passed in `branch-1.5` without any change.
##########
File path: java/core/src/test/org/apache/orc/impl/TestRecordReaderImpl.java
##########
@@ -112,6 +112,16 @@ public void testFindColumn() throws Exception {
assertEquals(3, RecordReaderImpl.findColumns(evo, "e"));
}
+ @Test
+ public void testFindColumnCaseInsensitively() throws Exception {
Review comment:
This passed in `branch-1.5` with no change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org