You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by rf...@apache.org on 2008/10/07 23:05:07 UTC

svn commit: r702639 - in /tuscany/java/sca/modules/tracing-aspectj/src/main/java/org/apache/tuscany/sca/aspectj: SimpleTracingAspect.java TracingAspect.java

Author: rfeng
Date: Tue Oct  7 14:05:07 2008
New Revision: 702639

URL: http://svn.apache.org/viewvc?rev=702639&view=rev
Log:
Only trace the public methods on tuscany classes

Modified:
    tuscany/java/sca/modules/tracing-aspectj/src/main/java/org/apache/tuscany/sca/aspectj/SimpleTracingAspect.java
    tuscany/java/sca/modules/tracing-aspectj/src/main/java/org/apache/tuscany/sca/aspectj/TracingAspect.java

Modified: tuscany/java/sca/modules/tracing-aspectj/src/main/java/org/apache/tuscany/sca/aspectj/SimpleTracingAspect.java
URL: http://svn.apache.org/viewvc/tuscany/java/sca/modules/tracing-aspectj/src/main/java/org/apache/tuscany/sca/aspectj/SimpleTracingAspect.java?rev=702639&r1=702638&r2=702639&view=diff
==============================================================================
--- tuscany/java/sca/modules/tracing-aspectj/src/main/java/org/apache/tuscany/sca/aspectj/SimpleTracingAspect.java (original)
+++ tuscany/java/sca/modules/tracing-aspectj/src/main/java/org/apache/tuscany/sca/aspectj/SimpleTracingAspect.java Tue Oct  7 14:05:07 2008
@@ -37,10 +37,10 @@
 
     @Override
     protected void completeLog() {
-        System.out.println("completeLog()");
+        System.out.println("<<< ----------------------------------------------------");
     }
 
-    @Pointcut("execution(public * org.apache.tuscany.sca..*.*(..)) &&!within(java..*)")
+    @Pointcut("execution(public * org.apache.tuscany.sca..*.*(..))")
     protected void entry() {
     }
 
@@ -76,7 +76,7 @@
 
     @Override
     protected void startLog() {
-        System.out.println("startLog()");
+        System.out.println(">>> ----------------------------------------------------");
     }
 
 }

Modified: tuscany/java/sca/modules/tracing-aspectj/src/main/java/org/apache/tuscany/sca/aspectj/TracingAspect.java
URL: http://svn.apache.org/viewvc/tuscany/java/sca/modules/tracing-aspectj/src/main/java/org/apache/tuscany/sca/aspectj/TracingAspect.java?rev=702639&r1=702638&r2=702639&view=diff
==============================================================================
--- tuscany/java/sca/modules/tracing-aspectj/src/main/java/org/apache/tuscany/sca/aspectj/TracingAspect.java (original)
+++ tuscany/java/sca/modules/tracing-aspectj/src/main/java/org/apache/tuscany/sca/aspectj/TracingAspect.java Tue Oct  7 14:05:07 2008
@@ -41,15 +41,16 @@
     @Pointcut("")
     protected abstract void withinScope();
 
-    @Pointcut("withinScope() && call(* java..*.*(..))")
+    @Pointcut("call(* java..*.*(..))")
     protected void exit() {
     }
 
-    @Pointcut("withinScope() && entry() && !cflowbelow(entry())")
+    @Pointcut("entry() && !cflowbelow(entry())")
     void start() {
     }
 
-    @Pointcut("withinScope() && cflow(entry()) && !cflowbelow(exit()) && !within(org.apache.tuscany.sca.aspectj.*Aspect)")
+    // @Pointcut("withinScope() && cflow(entry()) && !cflow(exit()) && !within(org.apache.tuscany.sca.aspectj.*Aspect)")
+    @Pointcut("withinScope() && entry() && !within(org.apache.tuscany.sca.aspectj.*Aspect)")
     void trace() {
     }