svn commit: r1727160 - /apr/apr/trunk/include/apr_cstr.h

[wr...@apache.org]

Author: wrowe
Date: Wed Jan 27 19:31:17 2016
New Revision: 1727160

URL: http://svn.apache.org/viewvc?rev=1727160&view=rev
Log:
Agree with jim, that "case-equivalent unaccented Latin (C/POSIX ASCII subset)
alpha characters" literally means the values "A-Z" (all equivilant in case),
distinct from the values "a-z" (all equivilant in case).

We also can't say "ASCII" when we mean either "ASCII" or original "EBCDIC"
alpha characters, so rephrase this strictly in terms of C/POSIX, signify
the number of characters in that set, and explicitly call out that locale
is ignored...


Modified:
    apr/apr/trunk/include/apr_cstr.h

Modified: apr/apr/trunk/include/apr_cstr.h
URL: http://svn.apache.org/viewvc/apr/apr/trunk/include/apr_cstr.h?rev=1727160&r1=1727159&r2=1727160&view=diff
==============================================================================
--- apr/apr/trunk/include/apr_cstr.h (original)
+++ apr/apr/trunk/include/apr_cstr.h Wed Jan 27 19:31:17 2016
@@ -146,8 +146,9 @@ char * apr_cstr_join(const apr_array_hea
 
 /**
  * Perform a case-insensitive comparison of two strings @a atr1 and @a atr2,
- * treating case-equivalent unaccented Latin (C/POSIX ASCII subset) alpha
- * characters as equal.
+ * treating upper and lower case values of the 26 standard C/POSIX alphabetic
+ * characters as equivilant. Extended latin characters outside of this set
+ * are treated as unique octets, irrespective of the current locale.
  *
  * Returns in integer greater than, equal to, or less than 0,
  * according to whether @a str1 is considered greater than, equal to,
@@ -159,8 +160,9 @@ int apr_cstr_casecmp(const char *str1, c
 
 /**
  * Perform a case-insensitive comparison of two strings @a atr1 and @a atr2,
- * of @n (or shorter) length, treating case-equivalent unaccented Latin
- * (C/POSIX ASCII subset) alpha characters as equal.
+ * treating upper and lower case values of the 26 standard C/POSIX alphabetic
+ * characters as equivilant. Extended latin characters outside of this set
+ * are treated as unique octets, irrespective of the current locale.
  *
  * Returns in integer greater than, equal to, or less than 0,
  * according to whether @a str1 is considered greater than, equal to,

Re: svn commit: r1727160 - /apr/apr/trunk/include/apr_cstr.h

[Mike Rumph <mi...@oracle.com>]

On 1/27/2016 11:31 AM, wrowe@apache.org wrote:
> --- apr/apr/trunk/include/apr_cstr.h (original)
> +++ apr/apr/trunk/include/apr_cstr.h Wed Jan 27 19:31:17 2016
> @@ -146,8 +146,9 @@ char * apr_cstr_join(const apr_array_hea
>   
>   /**
>    * Perform a case-insensitive comparison of two strings @a atr1 and @a atr2,
> - * treating case-equivalent unaccented Latin (C/POSIX ASCII subset) alpha
> - * characters as equal.
> + * treating upper and lower case values of the 26 standard C/POSIX alphabetic
> + * characters as equivilant. Extended latin characters outside of this set
Seems like a strange spelling for the word "equivalent".
> + * are treated as unique octets, irrespective of the current locale.
>