You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/09/09 18:20:58 UTC
[GitHub] [couchdb] nickva opened a new pull request #3139: Handle malformed URLs when stripping URL creds in couch_replicator
nickva opened a new pull request #3139:
URL: https://github.com/apache/couchdb/pull/3139
Previously there was an error thrown which prevented emitting _scheduler/docs responses. Instead of throwing an error, return `null` if the URL cannot be parsed.
This is a back-port to 3x. of the PR on master https://github.com/apache/couchdb/pull/3138
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #3139: Handle malformed URLs when stripping URL creds in couch_replicator
Posted by GitBox <gi...@apache.org>.
nickva merged pull request #3139:
URL: https://github.com/apache/couchdb/pull/3139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #3139: Handle malformed URLs when stripping URL creds in couch_replicator
Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #3139:
URL: https://github.com/apache/couchdb/pull/3139#issuecomment-689737508
@wohali thanks for taking a look, it's not as critical I think. Users can mitigate the error by simply deleting the malformed document from their _replicator dbs, so let's stick with what we have for 3.1.1 already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] wohali commented on pull request #3139: Handle malformed URLs when stripping URL creds in couch_replicator
Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #3139:
URL: https://github.com/apache/couchdb/pull/3139#issuecomment-689735840
@nickva if I don't put this in 3.1.1 is it crucial? I've already finished the release notes, is why I ask.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] wohali commented on pull request #3139: Handle malformed URLs when stripping URL creds in couch_replicator
Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #3139:
URL: https://github.com/apache/couchdb/pull/3139#issuecomment-689735984
To be clear, still backport this. It just might not make 3.1.1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org