You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by novicr <gi...@git.apache.org> on 2018/11/28 16:22:11 UTC

[GitHub] ignite pull request #5528: Continuous query node restart

GitHub user novicr opened a pull request:

    https://github.com/apache/ignite/pull/5528

    Continuous query node restart

    Add a test showing there is a problem with setting remote filter factory on continuous query.  
    
    Steps to reproduce:
    1. Start 4 node cluster
    2. Create a ContinuousQuery
    3. Set remote filter factory on the query (both factory and filter are Serializable)
    4. Stop one server node
    5. Start the node stopped in previous step
    
    In step 5 when starting the node
    `[2018-11-28 11:14:55,061][ERROR][tcp-disco-msg-worker-#40%continuous.CacheContinuousQueryRestartTest2%][TcpDiscoverySpi] Runtime error caught during grid runnable execution: IgniteSpiThread [name=tcp-disco-msg-worker-#40%continuous.CacheContinuousQueryRestartTest2%]
    java.lang.AssertionError
    	at org.apache.ignite.internal.processors.cache.query.continuous.CacheContinuousQueryHandlerV2.getEventFilter(CacheContinuousQueryHandlerV2.java:104)
    `
    The actual failing code: 
    `assert rmtFilterFactory != null;`
    
    Looks like the filter factory is not propagated to the remote node.
    
    _Note:_ When I use setRemoteFilter() (which is now decommissioned) everything works as expected.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/novicr/ignite continuous-query-node-restart

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/5528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5528
    
----
commit 22d70239357a6e567c6d779588db56f44a0604b2
Author: novicr <43...@...>
Date:   2018-10-02T18:51:14Z

    Merge pull request #2 from apache/master
    
    pull latest into fork

commit 99030d8b430b1cb94d41f5d2f7bd405505cd659b
Author: novicr <43...@...>
Date:   2018-10-03T19:54:12Z

    add test to show sql query missing data when partitions are lost (#3)
    
    * add test to show sql query missing data when partitions are lost
    
    * add READ_WRITE_NONE lost partition policy
    
    * set partition loss policy
    
    * Revert: add READ_WRITE_NONE lost partition policy

commit 71d79c553301c27811777eed55e4314c2f771af4
Author: novicr <43...@...>
Date:   2018-10-08T12:25:27Z

    Merge pull request #4 from apache/master
    
    update fork

commit 85436863ce42b5032dcd19c76a472e7dd44f08fb
Author: romannovichenok <ro...@...>
Date:   2018-11-28T16:04:18Z

    Add test to show remote filter factory missing when restarting node during continuous query.

----


---

Re: [GitHub] ignite pull request #5528: Continuous query node restart fails when remote filter factory is defined

Posted by novicr <ro...@gmail.com>.

Looks like this issue has already been filed:
https://issues.apache.org/jira/browse/IGNITE-9181

The actual failing code: 
    `assert rmtFilterFactory != null;` 
    
    Looks like the filter factory is not propagated to the remote node. 
    
    Note: When I use setRemoteFilter() (which is now decommissioned)
everything works as expected. 




--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/