You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/02/16 14:41:26 UTC

[GitHub] [ratis] szetszwo commented on pull request #602: RATIS-1525. Add step down leader proto and client related code

szetszwo commented on pull request #602:
URL: https://github.com/apache/ratis/pull/602#issuecomment-1041561733


   @codings-dan , could you also remove `RaftServerImpl.setLeaderElectionPause`.  It is never used.
   ```
   @@ -1448,11 +1452,6 @@ class RaftServerImpl implements RaftServer.Division,
        return reply;
      }
    
   -  void setLeaderElectionPause(boolean pause) throws ServerNotReadyException {
   -    assertLifeCycleState(LifeCycle.States.RUNNING);
   -    role.setLeaderElectionPause(pause);
   -  }
   -
      boolean pause() {
        // TODO: should pause() be limited on only working for a follower?
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org